All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Jun Nie <jun.nie@linaro.org>,
	andre.przywara@arm.com, linux@arm.linux.org.uk,
	graeme.gregory@linaro.org, peter@hurleysoftware.com,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, shawn.guo@linaro.org
Cc: jason.liu@linaro.org
Subject: Re: [PATCH 1/2] serial: amba-pl011: make platform driver generic
Date: Mon, 21 Mar 2016 14:47:17 -0500	[thread overview]
Message-ID: <56F04FC5.7040907@codeaurora.org> (raw)
In-Reply-To: <1457920282-14823-1-git-send-email-jun.nie@linaro.org>

Jun Nie wrote:

> -	snprintf(uap->type, sizeof(uap->type), "SBSA");
> +	snprintf(uap->type, sizeof(uap->type), "PL011 plat");

I'm not crazy about this.  I think you need to add a "const char *name" 
field to 'struct vendor_data'.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.

WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] serial: amba-pl011: make platform driver generic
Date: Mon, 21 Mar 2016 14:47:17 -0500	[thread overview]
Message-ID: <56F04FC5.7040907@codeaurora.org> (raw)
In-Reply-To: <1457920282-14823-1-git-send-email-jun.nie@linaro.org>

Jun Nie wrote:

> -	snprintf(uap->type, sizeof(uap->type), "SBSA");
> +	snprintf(uap->type, sizeof(uap->type), "PL011 plat");

I'm not crazy about this.  I think you need to add a "const char *name" 
field to 'struct vendor_data'.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.

  parent reply	other threads:[~2016-03-21 19:47 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  1:51 [PATCH 1/2] serial: amba-pl011: make platform driver generic Jun Nie
2016-03-14  1:51 ` Jun Nie
2016-03-14  1:51 ` [PATCH 2/2] serial: amba-pl011: complete support to ZTE uart Jun Nie
2016-03-14  1:51   ` Jun Nie
2016-03-21 20:39   ` Timur Tabi
2016-03-21 20:39     ` Timur Tabi
2016-03-22  1:16     ` Jun Nie
2016-03-22  1:16       ` Jun Nie
2016-03-22  1:55       ` Timur Tabi
2016-03-22  1:55         ` Timur Tabi
2016-03-22  2:01         ` Jun Nie
2016-03-22  2:01           ` Jun Nie
2016-03-22  2:06           ` Timur Tabi
2016-03-22  2:06             ` Timur Tabi
2016-03-22  2:17             ` Jun Nie
2016-03-22  2:17               ` Jun Nie
2016-03-22  8:20               ` G Gregory
2016-03-22  8:20                 ` G Gregory
2016-03-22  8:44                 ` Jun Nie
2016-03-22  8:44                   ` Jun Nie
2016-03-22  8:51                   ` G Gregory
2016-03-22  8:51                     ` G Gregory
2016-03-21  7:33 ` [PATCH 1/2] serial: amba-pl011: make platform driver generic Jun Nie
2016-03-21  7:33   ` Jun Nie
2016-03-21 19:47 ` Timur Tabi [this message]
2016-03-21 19:47   ` Timur Tabi
2016-03-22  1:25   ` Jun Nie
2016-03-22  1:25     ` Jun Nie
2016-03-22  1:56     ` Timur Tabi
2016-03-22  1:56       ` Timur Tabi
2016-03-22 12:38 ` Russell King - ARM Linux
2016-03-22 12:38   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F04FC5.7040907@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=andre.przywara@arm.com \
    --cc=graeme.gregory@linaro.org \
    --cc=jason.liu@linaro.org \
    --cc=jun.nie@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=peter@hurleysoftware.com \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.