From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Benjamin Poirier <bpoirier@suse.com>, netdev@vger.kernel.org
Cc: Salam Noureddine <noureddine@arista.com>
Subject: Re: [PATCH] net: Add missing kernel-doc for netdev ptype lists
Date: Mon, 21 Mar 2016 21:47:37 +0000 [thread overview]
Message-ID: <56F06BF9.6010004@osg.samsung.com> (raw)
In-Reply-To: <1458594508-14545-1-git-send-email-bpoirier@suse.com>
On 21/03/16 21:08, Benjamin Poirier wrote:
> .//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_all'
> .//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_specific'
>
> Introduced by commit 7866a621043f ("dev: add per net_device packet type
> chains")
>
> Cc: Salam Noureddine <noureddine@arista.com>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
> ---
> include/linux/netdevice.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 9a3d55c..1937bdd 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1418,6 +1418,8 @@ enum netdev_priv_flags {
> * @unreg_list: List entry, that is used, when we are unregistering the
> * device, see the function unregister_netdev
> * @close_list: List entry, that is used, when we are closing the device
> + * @ptype_all: Device-specific packet handlers for all protocols
> + * @ptype_specific: Device-specific, protocol-specific packet handlers
> *
> * @adj_list: Directly linked devices, like slaves for bonding
> * @all_adj_list: All linked devices, *including* neighbours
>
Looks good to me.
Thanks Benjamin :)
Luis
next prev parent reply other threads:[~2016-03-21 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 20:20 [PATCH] net: add missing descriptions in net_device_priv_flags Luis de Bethencourt
2016-03-21 20:41 ` Benjamin Poirier
2016-03-21 21:01 ` Luis de Bethencourt
2016-03-21 21:08 ` [PATCH] net: Add missing kernel-doc for netdev ptype lists Benjamin Poirier
2016-03-21 21:47 ` Luis de Bethencourt [this message]
2016-03-22 2:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F06BF9.6010004@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=bpoirier@suse.com \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.