From: Thomas Huth <thuth@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
qemu-devel@nongnu.org, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed
Date: Tue, 22 Mar 2016 16:46:04 +0100 [thread overview]
Message-ID: <56F168BC.2080208@redhat.com> (raw)
In-Reply-To: <1458604039-10161-1-git-send-email-samuel.thibault@ens-lyon.org>
On 22.03.2016 00:47, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> slirp/udp6.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/slirp/udp6.c b/slirp/udp6.c
> index 60a91c9..a23026f 100644
> --- a/slirp/udp6.c
> +++ b/slirp/udp6.c
> @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m)
> m->m_data -= iphlen;
> *ip = save_ip;
> DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno)));
> - /* TODO: ICMPv6 error */
> - /*icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));*/
> + icmp6_send_error(m, ICMP6_UNREACH, ICMP6_UNREACH_NO_ROUTE);
> goto bad;
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2016-03-22 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 23:47 [Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed Samuel Thibault
2016-03-22 15:46 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F168BC.2080208@redhat.com \
--to=thuth@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.