* [Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed
@ 2016-03-21 23:47 Samuel Thibault
2016-03-22 15:46 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Thibault @ 2016-03-21 23:47 UTC (permalink / raw)
To: qemu-devel, jan.kiszka, thuth; +Cc: Samuel Thibault
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
slirp/udp6.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/slirp/udp6.c b/slirp/udp6.c
index 60a91c9..a23026f 100644
--- a/slirp/udp6.c
+++ b/slirp/udp6.c
@@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m)
m->m_data -= iphlen;
*ip = save_ip;
DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno)));
- /* TODO: ICMPv6 error */
- /*icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));*/
+ icmp6_send_error(m, ICMP6_UNREACH, ICMP6_UNREACH_NO_ROUTE);
goto bad;
}
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed
2016-03-21 23:47 [Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed Samuel Thibault
@ 2016-03-22 15:46 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2016-03-22 15:46 UTC (permalink / raw)
To: Samuel Thibault, qemu-devel, jan.kiszka
On 22.03.2016 00:47, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> slirp/udp6.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/slirp/udp6.c b/slirp/udp6.c
> index 60a91c9..a23026f 100644
> --- a/slirp/udp6.c
> +++ b/slirp/udp6.c
> @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m)
> m->m_data -= iphlen;
> *ip = save_ip;
> DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno)));
> - /* TODO: ICMPv6 error */
> - /*icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));*/
> + icmp6_send_error(m, ICMP6_UNREACH, ICMP6_UNREACH_NO_ROUTE);
> goto bad;
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-22 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-21 23:47 [Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed Samuel Thibault
2016-03-22 15:46 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.