All of lore.kernel.org
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading
Date: Tue, 22 Mar 2016 21:12:56 +0100	[thread overview]
Message-ID: <56F1A748.6070808@suse.de> (raw)
In-Reply-To: <1458598418-16959-1-git-send-email-hdegoede@redhat.com>

Hi Hans,

Am 21.03.2016 um 23:13 schrieb Hans de Goede:
> Add a missing MODULE_DEVICE_TABLE() line which was causing the
> sunxi-musb glue to not auto-load when build as a module.

"built"

> 

Should this get a Fixes: header for backporting to stable?

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/usb/musb/sunxi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 4b472b8..9af9431 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
>  	{ .compatible = "allwinner,sun8i-a33-musb", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, sunxi_musb_match);
>  
>  static struct platform_driver sunxi_musb_driver = {
>  	.probe = sunxi_musb_probe,

Has anyone looked into my earlier report about the module filename not
having musb-? I did not see any response and haven't rechecked v4.5.0.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading
Date: Tue, 22 Mar 2016 21:12:56 +0100	[thread overview]
Message-ID: <56F1A748.6070808@suse.de> (raw)
In-Reply-To: <1458598418-16959-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Hi Hans,

Am 21.03.2016 um 23:13 schrieb Hans de Goede:
> Add a missing MODULE_DEVICE_TABLE() line which was causing the
> sunxi-musb glue to not auto-load when build as a module.

"built"

> 

Should this get a Fixes: header for backporting to stable?

> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/usb/musb/sunxi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 4b472b8..9af9431 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
>  	{ .compatible = "allwinner,sun8i-a33-musb", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, sunxi_musb_match);
>  
>  static struct platform_driver sunxi_musb_driver = {
>  	.probe = sunxi_musb_probe,

Has anyone looked into my earlier report about the module filename not
having musb-? I did not see any response and haven't rechecked v4.5.0.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2016-03-22 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 22:13 [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading Hans de Goede
2016-03-21 22:13 ` Hans de Goede
2016-03-22  0:33 ` Javier Martinez Canillas
2016-03-22  0:33   ` Javier Martinez Canillas
2016-03-22 20:12 ` Andreas Färber [this message]
2016-03-22 20:12   ` Andreas Färber
2016-03-22 20:52   ` [linux-sunxi] " Hans de Goede
2016-03-22 20:52     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F1A748.6070808@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.