From: "Liang, Cunming" <cunming.liang@intel.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] ixgbe: fix vector RX can't always set packet_type properly
Date: Wed, 23 Mar 2016 10:54:23 +0800 [thread overview]
Message-ID: <56F2055F.80905@intel.com> (raw)
In-Reply-To: <1458657017-22160-1-git-send-email-konstantin.ananyev@intel.com>
Hi,
On 3/22/2016 10:30 PM, Konstantin Ananyev wrote:
> Fixes: 39625417585 ("mbuf: redefine packet type")
>
> Current vector RX can't always set packet_type properly.
> To be more specific:
> a) it never sets RTE_PTYPE_L2_ETHER
> b) it doesn't handle tunnel ipv4/ipv6 case correctly.
> c) it doesn't check is IXGBE_RXDADV_PKTTYPE_ETQF set or not.
> While a) is pretty easy to fix, b) and c) are not that straightforward
> in terms of SIMD ops (specially b).
> So far I wasn't able to make vRX support packet_type properly without
> noticeable performance loss.
> So for now, just remove that functionality at all from vector RX and
> update dev_supported_ptypes_get().
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 4 +---
> drivers/net/ixgbe/ixgbe_rxtx_vec.c | 34 +++++++++++-----------------------
> 2 files changed, 12 insertions(+), 26 deletions(-)
>
>
Acked-by: Liang Cunming <cunming.liang@intel.com>
next prev parent reply other threads:[~2016-03-23 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 14:30 [PATCH] ixgbe: fix vector RX can't always set packet_type properly Konstantin Ananyev
2016-03-23 2:54 ` Liang, Cunming [this message]
2016-03-24 12:25 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F2055F.80905@intel.com \
--to=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.