[PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 12:07 ` Vaishali Thakkar
  0 siblings, 0 replies; 10+ messages in thread
From: Vaishali Thakkar @ 2016-03-23 12:07 UTC (permalink / raw)
  To: akpm
  Cc: linux-kernel, linux-mm, n-horiguchi, mike.kravetz, hillf.zj,
	mhocko, baiyaowei, dingel, kirill.shutemov, dave.hansen,
	paul.gortmaker, catalin.marinas, will.deacon, cmetcalf,
	linux-arm-kernel, james.hogan, linux-metag, benh, paulus, mpe,
	linuxppc-dev, tglx, mingo, hpa, x86, Vaishali Thakkar

Current code fails to ignore the 'hugepages=' parameters when unsupported
hugepagesize is specified. With this patchset, introduce new architecture
independent routine hugetlb_bad_size to handle such command line options.
And then call it in architecture specific code.

Changes since v1:
	- Separated different architecture specific changes in different
	  patches
	- CC'ed all arch maintainers

Vaishali Thakkar (6):
  mm/hugetlb: Introduce hugetlb_bad_size
  arm64: mm: Use hugetlb_bad_size
  metag: mm: Use hugetlb_bad_size
  powerpc: mm: Use hugetlb_bad_size
  tile: mm: Use hugetlb_bad_size
  x86: mm: Use hugetlb_bad_size

 arch/arm64/mm/hugetlbpage.c   |  1 +
 arch/metag/mm/hugetlbpage.c   |  1 +
 arch/powerpc/mm/hugetlbpage.c |  6 ++++--
 arch/tile/mm/hugetlbpage.c    |  7 ++++++-
 arch/x86/mm/hugetlbpage.c     |  1 +
 include/linux/hugetlb.h       |  1 +
 mm/hugetlb.c                  | 14 +++++++++++++-
 7 files changed, 27 insertions(+), 4 deletions(-)

-- 
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 12:07 ` Vaishali Thakkar
  0 siblings, 0 replies; 10+ messages in thread
From: Vaishali Thakkar @ 2016-03-23 12:07 UTC (permalink / raw)
  To: linux-arm-kernel

Current code fails to ignore the 'hugepages=' parameters when unsupported
hugepagesize is specified. With this patchset, introduce new architecture
independent routine hugetlb_bad_size to handle such command line options.
And then call it in architecture specific code.

Changes since v1:
	- Separated different architecture specific changes in different
	  patches
	- CC'ed all arch maintainers

Vaishali Thakkar (6):
  mm/hugetlb: Introduce hugetlb_bad_size
  arm64: mm: Use hugetlb_bad_size
  metag: mm: Use hugetlb_bad_size
  powerpc: mm: Use hugetlb_bad_size
  tile: mm: Use hugetlb_bad_size
  x86: mm: Use hugetlb_bad_size

 arch/arm64/mm/hugetlbpage.c   |  1 +
 arch/metag/mm/hugetlbpage.c   |  1 +
 arch/powerpc/mm/hugetlbpage.c |  6 ++++--
 arch/tile/mm/hugetlbpage.c    |  7 ++++++-
 arch/x86/mm/hugetlbpage.c     |  1 +
 include/linux/hugetlb.h       |  1 +
 mm/hugetlb.c                  | 14 +++++++++++++-
 7 files changed, 27 insertions(+), 4 deletions(-)

-- 
2.1.4

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 12:07 ` Vaishali Thakkar
  0 siblings, 0 replies; 10+ messages in thread
From: Vaishali Thakkar @ 2016-03-23 12:07 UTC (permalink / raw)
  To: akpm
  Cc: linux-kernel, linux-mm, n-horiguchi, mike.kravetz, hillf.zj,
	mhocko, baiyaowei, dingel, kirill.shutemov, dave.hansen,
	paul.gortmaker, catalin.marinas, will.deacon, cmetcalf,
	linux-arm-kernel, james.hogan, linux-metag, benh, paulus, mpe,
	linuxppc-dev, tglx, mingo, hpa, x86, Vaishali Thakkar

Current code fails to ignore the 'hugepages=' parameters when unsupported
hugepagesize is specified. With this patchset, introduce new architecture
independent routine hugetlb_bad_size to handle such command line options.
And then call it in architecture specific code.

Changes since v1:
	- Separated different architecture specific changes in different
	  patches
	- CC'ed all arch maintainers

Vaishali Thakkar (6):
  mm/hugetlb: Introduce hugetlb_bad_size
  arm64: mm: Use hugetlb_bad_size
  metag: mm: Use hugetlb_bad_size
  powerpc: mm: Use hugetlb_bad_size
  tile: mm: Use hugetlb_bad_size
  x86: mm: Use hugetlb_bad_size

 arch/arm64/mm/hugetlbpage.c   |  1 +
 arch/metag/mm/hugetlbpage.c   |  1 +
 arch/powerpc/mm/hugetlbpage.c |  6 ++++--
 arch/tile/mm/hugetlbpage.c    |  7 ++++++-
 arch/x86/mm/hugetlbpage.c     |  1 +
 include/linux/hugetlb.h       |  1 +
 mm/hugetlb.c                  | 14 +++++++++++++-
 7 files changed, 27 insertions(+), 4 deletions(-)

-- 
2.1.4

^ permalink raw reply	[flat|nested] 10+ messages in thread

[parent not found: <1458734844-14833-1-git-send-email-vaishali.thakkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

* Re: [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
  2016-03-23 12:07 ` Vaishali Thakkar
  (?)
  (?)
@ 2016-03-23 13:30     ` Michal Hocko
  -1 siblings, 0 replies; 10+ messages in thread
From: Michal Hocko @ 2016-03-23 13:30 UTC (permalink / raw)
  To: Vaishali Thakkar
  Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
	n-horiguchi-PaJj6Psr51x8UrSeD/g0lQ,
	mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA,
	hillf.zj-gPhfCIXyaqCqndwCJWfcng,
	baiyaowei-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/,
	dingel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
	kirill.shutemov-VuQAYsv1563Yd54FQh9/CA,
	dave.hansen-VuQAYsv1563Yd54FQh9/CA,
	paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ,
	catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8,
	cmetcalf-d5a29ZRxExrQT0dZR+AlfA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	james.hogan-1AXoQHu6uovQT0dZR+AlfA,
	linux-metag-u79uwXL29TY76Z2rM5mHXA,
	benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r,
	paulus-eUNUBHrolfbYtjvyW6yDsg, mpe-Gsx/Oe8HsFggBc27wqDAHg,
	linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, tglx-hfZtesqFncYOwBW4kG4KsQ,
	mingo-H+wXaHxf7aLQT0dZR+AlfA, hpa-YMNOUZJC4hwAvxtiuMwx3w,
	x86-DgEjT+Ai2ygdnm+yROfE0A

On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote:
> Current code fails to ignore the 'hugepages=' parameters when unsupported
> hugepagesize is specified. With this patchset, introduce new architecture
> independent routine hugetlb_bad_size to handle such command line options.
> And then call it in architecture specific code.
> 
> Changes since v1:
> 	- Separated different architecture specific changes in different
> 	  patches
> 	- CC'ed all arch maintainers

The hugetlb parameters parsing is a bit mess but this at least makes it
behave more consistently. Feel free to add to all patches
Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>

On a side note. I have received patches with broken threading - the
follow up patches are not in the single thread under this cover email.
I thought this was the default behavior of git send-email but maybe your
(older) version doesn't do that. --thread option would enforce that
(with --no-chain-reply-to) or you can set it up in the git config. IMHO
it is always better to have the patchset in the single email thread.

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 13:30     ` Michal Hocko
  0 siblings, 0 replies; 10+ messages in thread
From: Michal Hocko @ 2016-03-23 13:30 UTC (permalink / raw)
  To: Vaishali Thakkar
  Cc: akpm, linux-kernel, linux-mm, n-horiguchi, mike.kravetz, hillf.zj,
	baiyaowei, dingel, kirill.shutemov, dave.hansen, paul.gortmaker,
	catalin.marinas, will.deacon, cmetcalf, linux-arm-kernel,
	james.hogan, linux-metag, benh, paulus, mpe, linuxppc-dev, tglx,
	mingo, hpa, x86

On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote:
> Current code fails to ignore the 'hugepages=' parameters when unsupported
> hugepagesize is specified. With this patchset, introduce new architecture
> independent routine hugetlb_bad_size to handle such command line options.
> And then call it in architecture specific code.
> 
> Changes since v1:
> 	- Separated different architecture specific changes in different
> 	  patches
> 	- CC'ed all arch maintainers

The hugetlb parameters parsing is a bit mess but this at least makes it
behave more consistently. Feel free to add to all patches
Acked-by: Michal Hocko <mhocko@suse.com>

On a side note. I have received patches with broken threading - the
follow up patches are not in the single thread under this cover email.
I thought this was the default behavior of git send-email but maybe your
(older) version doesn't do that. --thread option would enforce that
(with --no-chain-reply-to) or you can set it up in the git config. IMHO
it is always better to have the patchset in the single email thread.

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 13:30     ` Michal Hocko
  0 siblings, 0 replies; 10+ messages in thread
From: Michal Hocko @ 2016-03-23 13:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote:
> Current code fails to ignore the 'hugepages=' parameters when unsupported
> hugepagesize is specified. With this patchset, introduce new architecture
> independent routine hugetlb_bad_size to handle such command line options.
> And then call it in architecture specific code.
> 
> Changes since v1:
> 	- Separated different architecture specific changes in different
> 	  patches
> 	- CC'ed all arch maintainers

The hugetlb parameters parsing is a bit mess but this at least makes it
behave more consistently. Feel free to add to all patches
Acked-by: Michal Hocko <mhocko@suse.com>

On a side note. I have received patches with broken threading - the
follow up patches are not in the single thread under this cover email.
I thought this was the default behavior of git send-email but maybe your
(older) version doesn't do that. --thread option would enforce that
(with --no-chain-reply-to) or you can set it up in the git config. IMHO
it is always better to have the patchset in the single email thread.

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 13:30     ` Michal Hocko
  0 siblings, 0 replies; 10+ messages in thread
From: Michal Hocko @ 2016-03-23 13:30 UTC (permalink / raw)
  To: Vaishali Thakkar
  Cc: akpm, linux-kernel, linux-mm, n-horiguchi, mike.kravetz, hillf.zj,
	baiyaowei, dingel, kirill.shutemov, dave.hansen, paul.gortmaker,
	catalin.marinas, will.deacon, cmetcalf, linux-arm-kernel,
	james.hogan, linux-metag, benh, paulus, mpe, linuxppc-dev, tglx,
	mingo, hpa, x86

On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote:
> Current code fails to ignore the 'hugepages=' parameters when unsupported
> hugepagesize is specified. With this patchset, introduce new architecture
> independent routine hugetlb_bad_size to handle such command line options.
> And then call it in architecture specific code.
> 
> Changes since v1:
> 	- Separated different architecture specific changes in different
> 	  patches
> 	- CC'ed all arch maintainers

The hugetlb parameters parsing is a bit mess but this at least makes it
behave more consistently. Feel free to add to all patches
Acked-by: Michal Hocko <mhocko@suse.com>

On a side note. I have received patches with broken threading - the
follow up patches are not in the single thread under this cover email.
I thought this was the default behavior of git send-email but maybe your
(older) version doesn't do that. --thread option would enforce that
(with --no-chain-reply-to) or you can set it up in the git config. IMHO
it is always better to have the patchset in the single email thread.

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
  2016-03-23 13:30     ` Michal Hocko
  (?)
@ 2016-03-23 16:01       ` Vaishali Thakkar
  -1 siblings, 0 replies; 10+ messages in thread
From: Vaishali Thakkar @ 2016-03-23 16:01 UTC (permalink / raw)
  To: Michal Hocko
  Cc: akpm, linux-kernel, linux-mm, n-horiguchi, mike.kravetz, hillf.zj,
	baiyaowei, dingel, kirill.shutemov, dave.hansen, paul.gortmaker,
	catalin.marinas, will.deacon, cmetcalf, linux-arm-kernel,
	james.hogan, linux-metag, benh, paulus, mpe, linuxppc-dev, tglx,
	mingo, hpa, x86



On Wednesday 23 March 2016 07:00 PM, Michal Hocko wrote:
> On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote:
>> Current code fails to ignore the 'hugepages=' parameters when unsupported
>> hugepagesize is specified. With this patchset, introduce new architecture
>> independent routine hugetlb_bad_size to handle such command line options.
>> And then call it in architecture specific code.
>>
>> Changes since v1:
>> 	- Separated different architecture specific changes in different
>> 	  patches
>> 	- CC'ed all arch maintainers
> The hugetlb parameters parsing is a bit mess but this at least makes it
> behave more consistently. Feel free to add to all patches
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> On a side note. I have received patches with broken threading - the
> follow up patches are not in the single thread under this cover email.
> I thought this was the default behavior of git send-email but maybe your
> (older) version doesn't do that. --thread option would enforce that
> (with --no-chain-reply-to) or you can set it up in the git config. IMHO
> it is always better to have the patchset in the single email thread.
>
Yes, now I have set up my git config for that. Hopefully, things will
work properly - patchset in a single thread from the next time.

Thanks.

-- 
Vaishali

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 16:01       ` Vaishali Thakkar
  0 siblings, 0 replies; 10+ messages in thread
From: Vaishali Thakkar @ 2016-03-23 16:01 UTC (permalink / raw)
  To: linux-arm-kernel



On Wednesday 23 March 2016 07:00 PM, Michal Hocko wrote:
> On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote:
>> Current code fails to ignore the 'hugepages=' parameters when unsupported
>> hugepagesize is specified. With this patchset, introduce new architecture
>> independent routine hugetlb_bad_size to handle such command line options.
>> And then call it in architecture specific code.
>>
>> Changes since v1:
>> 	- Separated different architecture specific changes in different
>> 	  patches
>> 	- CC'ed all arch maintainers
> The hugetlb parameters parsing is a bit mess but this at least makes it
> behave more consistently. Feel free to add to all patches
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> On a side note. I have received patches with broken threading - the
> follow up patches are not in the single thread under this cover email.
> I thought this was the default behavior of git send-email but maybe your
> (older) version doesn't do that. --thread option would enforce that
> (with --no-chain-reply-to) or you can set it up in the git config. IMHO
> it is always better to have the patchset in the single email thread.
>
Yes, now I have set up my git config for that. Hopefully, things will
work properly - patchset in a single thread from the next time.

Thanks.

-- 
Vaishali

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize
@ 2016-03-23 16:01       ` Vaishali Thakkar
  0 siblings, 0 replies; 10+ messages in thread
From: Vaishali Thakkar @ 2016-03-23 16:01 UTC (permalink / raw)
  To: Michal Hocko
  Cc: akpm, linux-kernel, linux-mm, n-horiguchi, mike.kravetz, hillf.zj,
	baiyaowei, dingel, kirill.shutemov, dave.hansen, paul.gortmaker,
	catalin.marinas, will.deacon, cmetcalf, linux-arm-kernel,
	james.hogan, linux-metag, benh, paulus, mpe, linuxppc-dev, tglx,
	mingo, hpa, x86



On Wednesday 23 March 2016 07:00 PM, Michal Hocko wrote:
> On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote:
>> Current code fails to ignore the 'hugepages=' parameters when unsupported
>> hugepagesize is specified. With this patchset, introduce new architecture
>> independent routine hugetlb_bad_size to handle such command line options.
>> And then call it in architecture specific code.
>>
>> Changes since v1:
>> 	- Separated different architecture specific changes in different
>> 	  patches
>> 	- CC'ed all arch maintainers
> The hugetlb parameters parsing is a bit mess but this at least makes it
> behave more consistently. Feel free to add to all patches
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> On a side note. I have received patches with broken threading - the
> follow up patches are not in the single thread under this cover email.
> I thought this was the default behavior of git send-email but maybe your
> (older) version doesn't do that. --thread option would enforce that
> (with --no-chain-reply-to) or you can set it up in the git config. IMHO
> it is always better to have the patchset in the single email thread.
>
Yes, now I have set up my git config for that. Hopefully, things will
work properly - patchset in a single thread from the next time.

Thanks.

-- 
Vaishali

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-03-23 16:03 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-23 12:07 [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize Vaishali Thakkar
2016-03-23 12:07 ` Vaishali Thakkar
2016-03-23 12:07 ` Vaishali Thakkar
     [not found] ` <1458734844-14833-1-git-send-email-vaishali.thakkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-03-23 13:30   ` Michal Hocko
2016-03-23 13:30     ` Michal Hocko
2016-03-23 13:30     ` Michal Hocko
2016-03-23 13:30     ` Michal Hocko
2016-03-23 16:01     ` Vaishali Thakkar
2016-03-23 16:01       ` Vaishali Thakkar
2016-03-23 16:01       ` Vaishali Thakkar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.