* Re: [Crash-utility] [PATCH 0/2] sparc64 support for crash utility
2016-03-23 18:40 [Crash-utility] [PATCH 0/2] sparc64 support for crash utility David Miller
@ 2016-03-23 20:41 ` Dave Kleikamp
0 siblings, 0 replies; 2+ messages in thread
From: Dave Kleikamp @ 2016-03-23 20:41 UTC (permalink / raw)
To: sparclinux
On 03/23/2016 03:06 PM, Dave Anderson wrote:
>
> Hi Dave,
>
> Welcome to the party after all these years.
>
> With any new architecture addition, one of the primary requirements
> for acceptance is that it in no way impacts any of the other architectures.
> This patchset was nicely done with that in mind, although there are two
> places in task.c where it does modify generic code:
>
> First, I prefer that the change in get_idle_threads() be segregated for
> SPARC64 only.
I can do that.
> The second change to task_flags() looks reasonable, but I would prefer
> that it be done differently. The reason it reads the flags with ULONG()
> is because originally it was an unsigned long. I'm not sure when the
> kernel changed it to an unsigned int, but interestingly enough, it's never
> been reported as a problem. In any case, to maintain backwards compatibility
> with older kernels, the read size should be based upon MEMBER_SIZE()
> instead of forcing it to use UINT() as you have done.
I thought about that, but it's been an unsigned int since 2.6.22.
Anyway, I'll make the change.
> And as far as sparc64.c, I did look at it, and it looks fine on paper,
> but I'll give you free reign as the sparc64 maintainer to do with it
> as you like. You will be my go-to sparc64 maintainer, correct?
I'd be happy to, unless Dave Miller wants to add it to his roles.
>
> Dave
>
>
>
> ----- Original Message -----
>> These patches add support for the sparc64 architecture.
>>
>> This supports running against a live kernel. Diskdump support is
>> also here, but the crashdump support for the kernel, kexec-tools,
>> and makedumpfile is still pending.
>>
>> Initial work was done by Karl Volz with help from Bob Picco.
>>
>> Dave Kleikamp (2):
>> sparc64 changes for gdb-7.6
>> sparc64 changes
>>
>> Makefile | 9 +-
>> configure.c | 23 +
>> defs.h | 190 ++++++++-
>> diskdump.c | 36 ++-
>> gdb-7.6.patch | 37 ++
>> lkcd_vmdump_v2_v3.h | 2 +-
>> sparc64.c | 1186
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>> symbols.c | 10 +
>> task.c | 11 +-
>> 9 files changed, 1496 insertions(+), 8 deletions(-)
>> create mode 100644 sparc64.c
>>
>> --
>> Crash-utility mailing list
>> Crash-utility@redhat.com
>> https://www.redhat.com/mailman/listinfo/crash-utility
>>
>
> --
> Crash-utility mailing list
> Crash-utility@redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
>
^ permalink raw reply [flat|nested] 2+ messages in thread