All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: Add new DCS commands in the enum list
@ 2016-03-24  9:18 Deepak M
  2016-03-24 12:39 ` Andrzej Hajda
  0 siblings, 1 reply; 2+ messages in thread
From: Deepak M @ 2016-03-24  9:18 UTC (permalink / raw)
  To: dri-devel; +Cc: Deepak M, Daniel Vetter

Adding new DCS commands which are specified in the
DCS 1.3 spec related to CABC.

Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Deepak M <m.deepak@intel.com>
---
 include/video/mipi_display.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
index ddcc8ca..bb8195b 100644
--- a/include/video/mipi_display.h
+++ b/include/video/mipi_display.h
@@ -117,6 +117,14 @@ enum {
 	MIPI_DCS_GET_SCANLINE		= 0x45,
 	MIPI_DCS_READ_DDB_START		= 0xA1,
 	MIPI_DCS_READ_DDB_CONTINUE	= 0xA8,
+	MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52,
+	MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F,
+	MIPI_DCS_GET_POWER_SAVE		= 0x56,
+	MIPI_DCS_GET_CONTROL_DISPLAY	= 0x54,
+	MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51,
+	MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E,
+	MIPI_DCS_WRITE_POWER_SAVE	= 0x55,
+	MIPI_DCS_WRITE_CONTROL_DISPLAY  = 0x53,
 };
 
 /* MIPI DCS pixel formats */
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm: Add new DCS commands in the enum list
  2016-03-24  9:18 [PATCH] drm: Add new DCS commands in the enum list Deepak M
@ 2016-03-24 12:39 ` Andrzej Hajda
  0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2016-03-24 12:39 UTC (permalink / raw)
  To: Deepak M, dri-devel; +Cc: Daniel Vetter

On 03/24/2016 10:18 AM, Deepak M wrote:
> Adding new DCS commands which are specified in the
> DCS 1.3 spec related to CABC.
> 
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Deepak M <m.deepak@intel.com>
> ---
>  include/video/mipi_display.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
> index ddcc8ca..bb8195b 100644
> --- a/include/video/mipi_display.h
> +++ b/include/video/mipi_display.h
> @@ -117,6 +117,14 @@ enum {
>  	MIPI_DCS_GET_SCANLINE		= 0x45,
>  	MIPI_DCS_READ_DDB_START		= 0xA1,
>  	MIPI_DCS_READ_DDB_CONTINUE	= 0xA8,
> +	MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52,
> +	MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F,
> +	MIPI_DCS_GET_POWER_SAVE		= 0x56,
> +	MIPI_DCS_GET_CONTROL_DISPLAY	= 0x54,
> +	MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51,
> +	MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E,
> +	MIPI_DCS_WRITE_POWER_SAVE	= 0x55,
> +	MIPI_DCS_WRITE_CONTROL_DISPLAY  = 0x53,

Please keep the list sorted by value.
Maybe it would be worth to add comment indicating spec version?
	MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52,		/* Spec 1.3 */

Regards
Andrzej



>  };
>  
>  /* MIPI DCS pixel formats */
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-24 12:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-24  9:18 [PATCH] drm: Add new DCS commands in the enum list Deepak M
2016-03-24 12:39 ` Andrzej Hajda

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.