All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Emilio López" <emilio.lopez@collabora.co.uk>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: devel@driverdev.osuosl.org, "Rob Clark" <robdclark@gmail.com>,
	"Daniel Stone" <daniels@collabora.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Riley Andrews" <riandrews@android.com>,
	"Greg Hackmann" <ghackmann@google.com>,
	linux-kselftest@vger.kernel.org,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour
Date: Mon, 28 Mar 2016 09:33:17 -0300	[thread overview]
Message-ID: <56F9248D.70100@collabora.co.uk> (raw)
In-Reply-To: <56E04BD6.9050502@osg.samsung.com>

El 09/03/16 a las 13:14, Shuah Khan escribió:
> On 03/09/2016 08:29 AM, Emilio López wrote:
>> One of the tests rely on a behaviour only observed on the driver currently
>> in use in Android. Disable it here until the behaviour is implemented
>> or it is decided it should not be implemented on the driver in mainline.
>>
>> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
>>
>> ---
>>
>>   tools/testing/selftests/sync/sync_test.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
>> index c3e4c01..3f484318 100644
>> --- a/tools/testing/selftests/sync/sync_test.c
>> +++ b/tools/testing/selftests/sync/sync_test.c
>> @@ -66,7 +66,14 @@ int main(void)
>>   	err += RUN_TEST(test_fence_one_timeline_merge);
>>   	err += RUN_TEST(test_fence_merge_same_fence);
>>   	err += RUN_TEST(test_fence_multi_timeline_wait);
>> +#if 0
>> +	/* The following test has been disabled due to differences
>> +	 * between the upstream and Android kernel drivers. The behaviour
>> +	 * that should occur when destroying a timeline with active fences
>> +	 * has not been defined yet.
>> +	 */
>>   	err += RUN_TEST(test_fence_wait_on_destroyed_timeline);
>> +#endif
>
> It would be useful to have a real define here that can be
> enabled later easily instead of if 0.

Ok, sounds good.

Thanks!
Emilio
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Emilio López" <emilio.lopez@collabora.co.uk>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: devel@driverdev.osuosl.org,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"Riley Andrews" <riandrews@android.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"John Harrison" <John.C.Harrison@Intel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Greg Hackmann" <ghackmann@google.com>,
	"Rob Clark" <robdclark@gmail.com>,
	linux-kselftest@vger.kernel.org,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Daniel Stone" <daniels@collabora.com>,
	"Arve Hjønnevåg" <arve@android.com>
Subject: Re: [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour
Date: Mon, 28 Mar 2016 09:33:17 -0300	[thread overview]
Message-ID: <56F9248D.70100@collabora.co.uk> (raw)
In-Reply-To: <56E04BD6.9050502@osg.samsung.com>

El 09/03/16 a las 13:14, Shuah Khan escribió:
> On 03/09/2016 08:29 AM, Emilio López wrote:
>> One of the tests rely on a behaviour only observed on the driver currently
>> in use in Android. Disable it here until the behaviour is implemented
>> or it is decided it should not be implemented on the driver in mainline.
>>
>> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
>>
>> ---
>>
>>   tools/testing/selftests/sync/sync_test.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
>> index c3e4c01..3f484318 100644
>> --- a/tools/testing/selftests/sync/sync_test.c
>> +++ b/tools/testing/selftests/sync/sync_test.c
>> @@ -66,7 +66,14 @@ int main(void)
>>   	err += RUN_TEST(test_fence_one_timeline_merge);
>>   	err += RUN_TEST(test_fence_merge_same_fence);
>>   	err += RUN_TEST(test_fence_multi_timeline_wait);
>> +#if 0
>> +	/* The following test has been disabled due to differences
>> +	 * between the upstream and Android kernel drivers. The behaviour
>> +	 * that should occur when destroying a timeline with active fences
>> +	 * has not been defined yet.
>> +	 */
>>   	err += RUN_TEST(test_fence_wait_on_destroyed_timeline);
>> +#endif
>
> It would be useful to have a real define here that can be
> enabled later easily instead of if 0.

Ok, sounds good.

Thanks!
Emilio

  reply	other threads:[~2016-03-28 12:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 15:28 [RFC PATCH v1 0/9] Tests for sync infrastructure Emilio López
2016-03-09 15:28 ` [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework Emilio López
2016-03-28 11:56   ` Emil Velikov
2016-03-28 11:56     ` Emil Velikov
2016-03-28 12:20     ` Emilio López
2016-03-28 12:20       ` Emilio López
2016-03-28 13:48       ` Emil Velikov
2016-03-28 13:48         ` Emil Velikov
2016-04-04  4:12         ` Emilio López
2016-04-07 14:47           ` Emil Velikov
2016-04-07 14:47             ` Emil Velikov
2016-03-09 15:28 ` [RFC PATCH v1 2/9] selftest: sync: fence " Emilio López
2016-03-09 15:28 ` [RFC PATCH v1 3/9] selftest: sync: merge " Emilio López
2016-03-09 15:28 ` [RFC PATCH v1 4/9] selftest: sync: wait " Emilio López
2016-03-09 15:28 ` [RFC PATCH v1 5/9] selftest: sync: destruction " Emilio López
2016-03-09 15:28 ` [RFC PATCH v1 6/9] selftest: sync: stress test for parallelism Emilio López
2016-03-09 15:29 ` [RFC PATCH v1 7/9] selftest: sync: stress consumer/producer test Emilio López
2016-03-09 15:29 ` [RFC PATCH v1 8/9] selftest: sync: stress test for merges Emilio López
2016-03-09 15:29 ` [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour Emilio López
2016-03-09 16:14   ` Shuah Khan
2016-03-09 16:14     ` Shuah Khan
2016-03-28 12:33     ` Emilio López [this message]
2016-03-28 12:33       ` Emilio López
2016-03-09 16:13 ` [RFC PATCH v1 0/9] Tests for sync infrastructure Shuah Khan
2016-03-09 16:13   ` Shuah Khan
2016-03-28 12:32   ` Emilio López
2016-03-28 12:32     ` Emilio López

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F9248D.70100@collabora.co.uk \
    --to=emilio.lopez@collabora.co.uk \
    --cc=John.C.Harrison@Intel.com \
    --cc=arve@android.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ghackmann@google.com \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=riandrews@android.com \
    --cc=robdclark@gmail.com \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.