From: Nathan Cutler <ncutler@suse.cz>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Fixes: lines in commit messages
Date: Mon, 28 Mar 2016 18:09:09 +0200 [thread overview]
Message-ID: <56F95725.3040407@suse.cz> (raw)
Greetings, Ceph developers:
As the number of GitHub pull requests rises (currently in the 8000s), we
are starting have trouble with unrelated PRs getting closed
automatically by the "Fixes: #...." lines in PR descriptions and commit
messages.
For example, if you open PR#9534 that fixes tracker issue#8069,
including a line "Fixes: #8069" will cause PR#8069 to be closed -
obviously, this is wrong but it's the way GitHub works.
Sage suggested that we work around this by referring to the tracker
issue by its full URL. I opened a PR changing SubmittingPatches to
reflect this:
https://github.com/ceph/ceph/pull/8312
Any objections?
--
Nathan Cutler
Software Engineer Distributed Storage
SUSE LINUX, s.r.o.
Tel.: +420 284 084 037
next reply other threads:[~2016-03-28 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 16:09 Nathan Cutler [this message]
2016-03-28 16:29 ` Fixes: lines in commit messages Gregory Farnum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F95725.3040407@suse.cz \
--to=ncutler@suse.cz \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.