* Fixes: lines in commit messages
@ 2016-03-28 16:09 Nathan Cutler
2016-03-28 16:29 ` Gregory Farnum
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Cutler @ 2016-03-28 16:09 UTC (permalink / raw)
To: Ceph Development
Greetings, Ceph developers:
As the number of GitHub pull requests rises (currently in the 8000s), we
are starting have trouble with unrelated PRs getting closed
automatically by the "Fixes: #...." lines in PR descriptions and commit
messages.
For example, if you open PR#9534 that fixes tracker issue#8069,
including a line "Fixes: #8069" will cause PR#8069 to be closed -
obviously, this is wrong but it's the way GitHub works.
Sage suggested that we work around this by referring to the tracker
issue by its full URL. I opened a PR changing SubmittingPatches to
reflect this:
https://github.com/ceph/ceph/pull/8312
Any objections?
--
Nathan Cutler
Software Engineer Distributed Storage
SUSE LINUX, s.r.o.
Tel.: +420 284 084 037
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fixes: lines in commit messages
2016-03-28 16:09 Fixes: lines in commit messages Nathan Cutler
@ 2016-03-28 16:29 ` Gregory Farnum
0 siblings, 0 replies; 2+ messages in thread
From: Gregory Farnum @ 2016-03-28 16:29 UTC (permalink / raw)
To: Nathan Cutler; +Cc: Ceph Development
On Mon, Mar 28, 2016 at 9:09 AM, Nathan Cutler <ncutler@suse.cz> wrote:
> Greetings, Ceph developers:
>
> As the number of GitHub pull requests rises (currently in the 8000s), we are
> starting have trouble with unrelated PRs getting closed automatically by the
> "Fixes: #...." lines in PR descriptions and commit messages.
>
> For example, if you open PR#9534 that fixes tracker issue#8069, including a
> line "Fixes: #8069" will cause PR#8069 to be closed - obviously, this is
> wrong but it's the way GitHub works.
>
> Sage suggested that we work around this by referring to the tracker issue by
> its full URL. I opened a PR changing SubmittingPatches to reflect this:
>
> https://github.com/ceph/ceph/pull/8312
>
> Any objections?
Sounds good to me. Truly depressing about GitHub, but sounds good.
-Greg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-28 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-28 16:09 Fixes: lines in commit messages Nathan Cutler
2016-03-28 16:29 ` Gregory Farnum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.