All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junichi Nomura <j-nomura@ce.jp.nec.com>
To: Al Viro <viro@zeniv.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: [regression 4.6-rc1] autofs lookup fails with -ENOENT
Date: Tue, 29 Mar 2016 00:35:11 +0000	[thread overview]
Message-ID: <56F9CDBF.7060306@ce.jp.nec.com> (raw)

Lookup of autofs files starts failing with -ENOENT on 4.6-rc1.

git-bisect tells commit e3c13928086f1 "namei: massage lookup_slow() to
be usable by lookup_one_len_unlocked()" as the first bad commit.

With the change, walk_component() does this:

    path.dentry = lookup_slow(&nd->last, nd->path.dentry,
                                          nd->flags);
    if (IS_ERR(path.dentry))
            return PTR_ERR(path.dentry);
    if (unlikely(d_is_negative(path.dentry))) {
            dput(path.dentry);
            return -ENOENT;
    }
    path.mnt = nd->path.mnt;
    err = follow_managed(&path, nd);
    if (unlikely(err < 0))
            return err;

It returns -ENOENT before handling automount in follow_managed().
Shouldn't it call follow_managed() before checking d_is_negative()?

--
Jun'ichi Nomura, NEC Corporation

                 reply	other threads:[~2016-03-29  0:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F9CDBF.7060306@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.