All of lore.kernel.org
 help / color / mirror / Atom feed
* [regression 4.6-rc1] autofs lookup fails with -ENOENT
@ 2016-03-29  0:35 Junichi Nomura
  0 siblings, 0 replies; only message in thread
From: Junichi Nomura @ 2016-03-29  0:35 UTC (permalink / raw)
  To: Al Viro, linux-fsdevel@vger.kernel.org

Lookup of autofs files starts failing with -ENOENT on 4.6-rc1.

git-bisect tells commit e3c13928086f1 "namei: massage lookup_slow() to
be usable by lookup_one_len_unlocked()" as the first bad commit.

With the change, walk_component() does this:

    path.dentry = lookup_slow(&nd->last, nd->path.dentry,
                                          nd->flags);
    if (IS_ERR(path.dentry))
            return PTR_ERR(path.dentry);
    if (unlikely(d_is_negative(path.dentry))) {
            dput(path.dentry);
            return -ENOENT;
    }
    path.mnt = nd->path.mnt;
    err = follow_managed(&path, nd);
    if (unlikely(err < 0))
            return err;

It returns -ENOENT before handling automount in follow_managed().
Shouldn't it call follow_managed() before checking d_is_negative()?

--
Jun'ichi Nomura, NEC Corporation

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-03-29  0:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-29  0:35 [regression 4.6-rc1] autofs lookup fails with -ENOENT Junichi Nomura

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.