[PATCH] f2fs: retrieve IO write stat from the right place

[PATCH] f2fs: retrieve IO write stat from the right place

[Shuoran Liu]

In the following patch,

    f2fs: split journal cache from curseg cache

journal cache is split from curseg cache. So IO write statistics should be
retrived from journal cache but not curseg->sum_blk. Otherwise, it will
get 0, and the stat is lost.

Signed-off-by: Shuoran Liu <liushuoran@huawei.com>
---
 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 15bb81f..e2787c8 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1442,7 +1442,7 @@ try_onemore:
 	seg_i = CURSEG_I(sbi, CURSEG_HOT_NODE);
 	if (__exist_node_summaries(sbi))
 		sbi->kbytes_written =
-			le64_to_cpu(seg_i->sum_blk->journal.info.kbytes_written);
+			le64_to_cpu(seg_i->journal->info.kbytes_written);
 
 	build_gc_manager(sbi);
 
-- 
1.9.1


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140

Re: [PATCH] f2fs: retrieve IO write stat from the right place

[Chao Yu]

On 2016/3/29 18:00, Shuoran Liu wrote:
> In the following patch,
> 
>     f2fs: split journal cache from curseg cache
> 
> journal cache is split from curseg cache. So IO write statistics should be
> retrived from journal cache but not curseg->sum_blk. Otherwise, it will
> get 0, and the stat is lost.

My bad, thanks for catching this.

Reviewed-by: Chao Yu <chao@kernel.org>

> 
> Signed-off-by: Shuoran Liu <liushuoran@huawei.com>
> ---
>  fs/f2fs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 15bb81f..e2787c8 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1442,7 +1442,7 @@ try_onemore:
>  	seg_i = CURSEG_I(sbi, CURSEG_HOT_NODE);
>  	if (__exist_node_summaries(sbi))
>  		sbi->kbytes_written =
> -			le64_to_cpu(seg_i->sum_blk->journal.info.kbytes_written);
> +			le64_to_cpu(seg_i->journal->info.kbytes_written);
>  
>  	build_gc_manager(sbi);
>  
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140