From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-block@vger.kernel.org>
Subject: Re: [PATCH 5/9] block: add ability to flag write back caching on a device
Date: Wed, 30 Mar 2016 09:46:32 -0600 [thread overview]
Message-ID: <56FBF4D8.9000203@fb.com> (raw)
In-Reply-To: <20160330154241.GA13131@infradead.org>
On 03/30/2016 09:42 AM, Christoph Hellwig wrote:
> On Wed, Mar 30, 2016 at 09:07:53AM -0600, Jens Axboe wrote:
>> Add an internal helper and flag for setting whether a queue has
>> write back caching, or write through (or none). Add a sysfs file
>> to show this as well, and make it changeable from user space.
>
> As per previous discussion: I don't really care about the way how we
> tell the block layer we have a writeback cache, but a NAK to having
> each driver call two interfaces to convey the same information.
>
> Please just look at q->flush_flag & REQ_FLUSH for now, and then
> improvem the interface if you don't like it (I don't particularly like
> it, but not to the point that I'm motivated enough to fix it :))
That's fine, I don't mind making that change, just didn't do it for this
version. I prefer if we change the cache flagging to be the primary way
to signal it, it's more intuitive than REQ_FLUSH.
It'll be in the next version.
--
Jens Axboe
next prev parent reply other threads:[~2016-03-30 15:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:07 [PATCHSET v3][RFC] Make background writeback not suck Jens Axboe
2016-03-30 15:07 ` [PATCH 1/9] writeback: propagate the various reasons for writeback Jens Axboe
2016-03-30 15:07 ` [PATCH 2/9] writeback: add wbc_to_write() Jens Axboe
2016-03-30 15:07 ` [PATCH 3/9] writeback: use WRITE_SYNC for reclaim or sync writeback Jens Axboe
2016-03-30 15:07 ` [PATCH 4/9] writeback: track if we're sleeping on progress in balance_dirty_pages() Jens Axboe
2016-04-13 13:08 ` Jan Kara
2016-04-13 14:20 ` Jens Axboe
2016-03-30 15:07 ` [PATCH 5/9] block: add ability to flag write back caching on a device Jens Axboe
2016-03-30 15:42 ` Christoph Hellwig
2016-03-30 15:46 ` Jens Axboe [this message]
2016-03-30 16:23 ` Jens Axboe
2016-03-30 17:29 ` Christoph Hellwig
2016-03-30 15:07 ` [PATCH 6/9] sd: inform block layer of write cache state Jens Axboe
2016-03-30 15:07 ` [PATCH 7/9] NVMe: " Jens Axboe
2016-03-30 15:07 ` [PATCH 8/9] block: add code to track actual device queue depth Jens Axboe
2016-03-30 15:07 ` [PATCH 9/9] writeback: throttle buffered writeback Jens Axboe
2016-03-31 8:24 ` [PATCHSET v3][RFC] Make background writeback not suck Dave Chinner
2016-03-31 14:29 ` Jens Axboe
2016-03-31 16:21 ` Jens Axboe
2016-04-01 0:56 ` Dave Chinner
2016-04-01 3:29 ` Jens Axboe
2016-04-01 3:33 ` Jens Axboe
2016-04-01 3:39 ` Jens Axboe
2016-04-01 6:16 ` Dave Chinner
2016-04-01 14:33 ` Jens Axboe
2016-04-01 5:04 ` Dave Chinner
2016-04-01 0:46 ` Dave Chinner
2016-04-01 3:25 ` Jens Axboe
2016-04-01 6:27 ` Dave Chinner
2016-04-01 14:34 ` Jens Axboe
2016-03-31 22:09 ` Holger Hoffstätte
2016-04-01 1:01 ` Dave Chinner
2016-04-01 1:01 ` Dave Chinner
2016-04-01 16:58 ` Holger Hoffstätte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBF4D8.9000203@fb.com \
--to=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.