From: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] regulator: Fix deadlock during regulator registration
Date: Wed, 30 Mar 2016 19:38:29 -0400 [thread overview]
Message-ID: <56FC6375.4060607@osg.samsung.com> (raw)
In-Reply-To: <20160330233427.GZ2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Hello Mark,
On 03/30/2016 07:34 PM, Mark Brown wrote:
> On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote:
>
>> You are doing some cleanup of the clean and scrub error paths by removing
>> rdev and returning ERR_PTR(ret) directly. I believe that should be in a
>> separate patch since is not related to the fix.
>
> There needs to be some reorganization due to the movement with the mutex
> handling.
>
Yes, I know. My point was that besides the reorganization that is needed,
he is removing some variables and that seemed like a separate change to me.
But of course you are the maintainer so ignore my comment if you don't mind
about that.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] regulator: Fix deadlock during regulator registration
Date: Wed, 30 Mar 2016 19:38:29 -0400 [thread overview]
Message-ID: <56FC6375.4060607@osg.samsung.com> (raw)
In-Reply-To: <20160330233427.GZ2350@sirena.org.uk>
Hello Mark,
On 03/30/2016 07:34 PM, Mark Brown wrote:
> On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote:
>
>> You are doing some cleanup of the clean and scrub error paths by removing
>> rdev and returning ERR_PTR(ret) directly. I believe that should be in a
>> separate patch since is not related to the fix.
>
> There needs to be some reorganization due to the movement with the mutex
> handling.
>
Yes, I know. My point was that besides the reorganization that is needed,
he is removing some variables and that seemed like a separate change to me.
But of course you are the maintainer so ignore my comment if you don't mind
about that.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-03-30 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 16:09 [PATCH] regulator: Fix deadlock during regulator registration Jon Hunter
2016-03-30 16:09 ` Jon Hunter
2016-03-30 16:18 ` Mark Brown
[not found] ` <20160330161831.GE2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-30 16:46 ` Jon Hunter
2016-03-30 16:46 ` Jon Hunter
2016-03-30 17:00 ` Mark Brown
[not found] ` <20160330170053.GK2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-30 17:41 ` Jon Hunter
2016-03-30 17:41 ` Jon Hunter
[not found] ` <1459354153-6352-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-30 23:25 ` Javier Martinez Canillas
2016-03-30 23:25 ` Javier Martinez Canillas
[not found] ` <56FC607D.3020108-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-03-30 23:34 ` Mark Brown
2016-03-30 23:34 ` Mark Brown
[not found] ` <20160330233427.GZ2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-30 23:38 ` Javier Martinez Canillas [this message]
2016-03-30 23:38 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC6375.4060607@osg.samsung.com \
--to=javier-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.