All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: Jiri Slaby <jslaby@suse.cz>, akpm@linux-foundation.org
Cc: kgdb-bugreport@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH -repost] kgdb: depends on VT
Date: Thu, 31 Mar 2016 07:01:45 -0500	[thread overview]
Message-ID: <56FD11A9.1060305@windriver.com> (raw)
In-Reply-To: <1459412955-4696-1-git-send-email-jslaby@suse.cz>

On 03/31/2016 03:29 AM, Jiri Slaby wrote:
> With VT=n, the kernel build fails with:
> drivers/built-in.o: In function `kgdboc_pre_exp_handler':
> kgdboc.c:(.text+0x7b5aa): undefined reference to `fg_console'
> kgdboc.c:(.text+0x7b5ce): undefined reference to `vc_cons'
> kgdboc.c:(.text+0x7b5d5): undefined reference to `vc_cons'
>
> kgdboc.o is built when KGDB_SERIAL_CONSOLE is set. So make
> KGDB_SERIAL_CONSOLE depend on HW_CONSOLE which includes those symbols.

Acked-by: Jason Wessel <jason.wessel@windriver.com>


I'll put this in the kgdb-next branch and submit it to the upstream, unless it gets merged in another queue.

Thanks!
Jason.

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140

WARNING: multiple messages have this Message-ID (diff)
From: Jason Wessel <jason.wessel@windriver.com>
To: Jiri Slaby <jslaby@suse.cz>, <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>,
	<kgdb-bugreport@lists.sourceforge.net>,
	<linux-serial@vger.kernel.org>
Subject: Re: [PATCH -repost] kgdb: depends on VT
Date: Thu, 31 Mar 2016 07:01:45 -0500	[thread overview]
Message-ID: <56FD11A9.1060305@windriver.com> (raw)
In-Reply-To: <1459412955-4696-1-git-send-email-jslaby@suse.cz>

On 03/31/2016 03:29 AM, Jiri Slaby wrote:
> With VT=n, the kernel build fails with:
> drivers/built-in.o: In function `kgdboc_pre_exp_handler':
> kgdboc.c:(.text+0x7b5aa): undefined reference to `fg_console'
> kgdboc.c:(.text+0x7b5ce): undefined reference to `vc_cons'
> kgdboc.c:(.text+0x7b5d5): undefined reference to `vc_cons'
>
> kgdboc.o is built when KGDB_SERIAL_CONSOLE is set. So make
> KGDB_SERIAL_CONSOLE depend on HW_CONSOLE which includes those symbols.

Acked-by: Jason Wessel <jason.wessel@windriver.com>


I'll put this in the kgdb-next branch and submit it to the upstream, unless it gets merged in another queue.

Thanks!
Jason.

  reply	other threads:[~2016-03-31 12:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31  8:29 [PATCH -repost] kgdb: depends on VT Jiri Slaby
2016-03-31 12:01 ` Jason Wessel [this message]
2016-03-31 12:01   ` Jason Wessel
2016-05-09  7:10   ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FD11A9.1060305@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=jslaby@suse.cz \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.