All of lore.kernel.org
 help / color / mirror / Atom feed
From: huawei.libin@huawei.com (Li Bin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq
Date: Thu, 31 Mar 2016 20:45:05 +0800	[thread overview]
Message-ID: <56FD1BD1.7070101@huawei.com> (raw)
In-Reply-To: <20160321102423.GB15150@dhcppc6.redhat.com>

Hi Pratyush,

on 2016/3/21 18:24, Pratyush Anand wrote:
> On 21/03/2016:08:37:50 AM, He Kuang wrote:
>> On arm64, watchpoint handler enables single-step to bypass the next
>> instruction for not recursive enter. If an irq is triggered right
>> after the watchpoint, a single-step will be wrongly triggered in irq
>> handler, which causes the watchpoint address not stepped over and
>> system hang.
> 
> Does patch [1] resolves this issue as well? I hope it should. Patch[1] has still
> not been sent for review. Your test result will be helpful.
> 
> ~Pratyush
> 
> [1] https://github.com/pratyushanand/linux/commit/7623c8099ac22eaa00e7e0f52430f7a4bd154652

This patch did not consider that, when excetpion return, the singlestep flag
should be restored, otherwise the right singlestep will not triggered.
Right?

Thanks,
Li Bin

> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: Li Bin <huawei.libin@huawei.com>
To: Pratyush Anand <panand@redhat.com>, He Kuang <hekuang@huawei.com>
Cc: <mark.rutland@arm.com>, <yang.shi@linaro.org>,
	<wangnan0@huawei.com>, <marc.zyngier@arm.com>,
	<catalin.marinas@arm.com>, <will.deacon@arm.com>,
	<linux-kernel@vger.kernel.org>, <richard@nod.at>,
	<james.morse@arm.com>, <hanjun.guo@linaro.org>,
	<gregkh@linuxfoundation.org>, <Dave.Martin@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Hanjun Guo <guohanjun@huawei.com>,
	Ding Tianhong <dingtianhong@huawei.com>
Subject: Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq
Date: Thu, 31 Mar 2016 20:45:05 +0800	[thread overview]
Message-ID: <56FD1BD1.7070101@huawei.com> (raw)
In-Reply-To: <20160321102423.GB15150@dhcppc6.redhat.com>

Hi Pratyush,

on 2016/3/21 18:24, Pratyush Anand wrote:
> On 21/03/2016:08:37:50 AM, He Kuang wrote:
>> On arm64, watchpoint handler enables single-step to bypass the next
>> instruction for not recursive enter. If an irq is triggered right
>> after the watchpoint, a single-step will be wrongly triggered in irq
>> handler, which causes the watchpoint address not stepped over and
>> system hang.
> 
> Does patch [1] resolves this issue as well? I hope it should. Patch[1] has still
> not been sent for review. Your test result will be helpful.
> 
> ~Pratyush
> 
> [1] https://github.com/pratyushanand/linux/commit/7623c8099ac22eaa00e7e0f52430f7a4bd154652

This patch did not consider that, when excetpion return, the singlestep flag
should be restored, otherwise the right singlestep will not triggered.
Right?

Thanks,
Li Bin

> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> .
> 

  parent reply	other threads:[~2016-03-31 12:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21  8:37 [PATCH 1/2] arm64: Store breakpoint single step state into pstate He Kuang
2016-03-21  8:37 ` He Kuang
2016-03-21  8:37 ` [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq He Kuang
2016-03-21  8:37   ` He Kuang
2016-03-21 10:24   ` Pratyush Anand
2016-03-21 10:24     ` Pratyush Anand
2016-03-21 10:38     ` Wangnan (F)
2016-03-21 10:38       ` Wangnan (F)
2016-03-21 11:05       ` Pratyush Anand
2016-03-21 11:05         ` Pratyush Anand
2016-03-31 12:45     ` Li Bin [this message]
2016-03-31 12:45       ` Li Bin
2016-04-04  5:17       ` Pratyush Anand
2016-04-04  5:17         ` Pratyush Anand
2016-04-07 11:34         ` Li Bin
2016-04-07 11:34           ` Li Bin
2016-04-08  5:14           ` Pratyush Anand
2016-04-08  5:14             ` Pratyush Anand
2016-04-08  8:07             ` Li Bin
2016-04-08  8:07               ` Li Bin
2016-04-08  8:58               ` Pratyush Anand
2016-04-08  8:58                 ` Pratyush Anand
2016-03-21 16:08 ` [PATCH 1/2] arm64: Store breakpoint single step state into pstate Will Deacon
2016-03-21 16:08   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FD1BD1.7070101@huawei.com \
    --to=huawei.libin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.