From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: cw00.choi@samsung.com
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Anand Moon" <linux.amoon@gmail.com>,
"Markus Reichl" <m.reichl@fivetechno.de>,
"Tobias Jakobi" <tjakobi@math.uni-bielefeld.de>,
"inki.dae@samsung.com" <inki.dae@samsung.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vg>
Subject: Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver
Date: Thu, 31 Mar 2016 14:54:28 +0200 [thread overview]
Message-ID: <56FD1E04.8050808@samsung.com> (raw)
In-Reply-To: <CAGTfZH0mgxyQPKBTX=ZXgtSn=bQ2zAMSNMHfO+OXh3U5qrUr4g@mail.gmail.com>
On 03/31/2016 02:28 PM, Chanwoo Choi wrote:
>> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions
>> > of which the return value is being tested return only ERR_PTR() values.
>> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs
>> > like
>> > if (IS_ERR_OR_NULL(result))
>> > return PTR_ERR(result);
>> >
>> > are not correct anyway.
>
> OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL()
Thanks, I forgot to mention there is similar issue in patches
5/20 and 6/20.
--
Regards
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver
Date: Thu, 31 Mar 2016 14:54:28 +0200 [thread overview]
Message-ID: <56FD1E04.8050808@samsung.com> (raw)
In-Reply-To: <CAGTfZH0mgxyQPKBTX=ZXgtSn=bQ2zAMSNMHfO+OXh3U5qrUr4g@mail.gmail.com>
On 03/31/2016 02:28 PM, Chanwoo Choi wrote:
>> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions
>> > of which the return value is being tested return only ERR_PTR() values.
>> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs
>> > like
>> > if (IS_ERR_OR_NULL(result))
>> > return PTR_ERR(result);
>> >
>> > are not correct anyway.
>
> OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL()
Thanks, I forgot to mention there is similar issue in patches
5/20 and 6/20.
--
Regards
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: cw00.choi@samsung.com
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Anand Moon" <linux.amoon@gmail.com>,
"Markus Reichl" <m.reichl@fivetechno.de>,
"Tobias Jakobi" <tjakobi@math.uni-bielefeld.de>,
"inki.dae@samsung.com" <inki.dae@samsung.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver
Date: Thu, 31 Mar 2016 14:54:28 +0200 [thread overview]
Message-ID: <56FD1E04.8050808@samsung.com> (raw)
In-Reply-To: <CAGTfZH0mgxyQPKBTX=ZXgtSn=bQ2zAMSNMHfO+OXh3U5qrUr4g@mail.gmail.com>
On 03/31/2016 02:28 PM, Chanwoo Choi wrote:
>> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions
>> > of which the return value is being tested return only ERR_PTR() values.
>> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs
>> > like
>> > if (IS_ERR_OR_NULL(result))
>> > return PTR_ERR(result);
>> >
>> > are not correct anyway.
>
> OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL()
Thanks, I forgot to mention there is similar issue in patches
5/20 and 6/20.
--
Regards
Sylwester
next prev parent reply other threads:[~2016-03-31 12:54 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 9:05 [PATCH v7 00/20] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 12:10 ` Sylwester Nawrocki
2016-03-31 12:10 ` Sylwester Nawrocki
2016-03-31 12:28 ` Chanwoo Choi
2016-03-31 12:28 ` Chanwoo Choi
2016-03-31 12:28 ` Chanwoo Choi
2016-03-31 12:54 ` Sylwester Nawrocki [this message]
2016-03-31 12:54 ` Sylwester Nawrocki
2016-03-31 12:54 ` Sylwester Nawrocki
[not found] ` <1459415165-32613-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-03-31 9:05 ` [PATCH v7 02/20] PM / devfreq: exynos: Add documentation for " Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 03/20] PM / devfreq: Add devfreq_get_devfreq_by_phandle() Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 04/20] PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 05/20] PM / devfreq: Add new passive governor Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 06/20] PM / devfreq: exynos: Add support of bus frequency of sub-blocks using " Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 07/20] PM / devfreq: exynos: Update documentation for bus devices " Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 08/20] PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 09/20] PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 10/20] MAINTAINERS: Add samsung bus frequency driver entry Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 11/20] ARM: dts: Add DMC bus node for Exynos3250 Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 12/20] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 13/20] ARM: dts: Add bus nodes using VDD_INT for Exynos3250 Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:05 ` [PATCH v7 14/20] ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12 Chanwoo Choi
2016-03-31 9:05 ` Chanwoo Choi
2016-03-31 9:06 ` [PATCH v7 15/20] ARM: dts: Add bus nodes using VDD_INT " Chanwoo Choi
2016-03-31 9:06 ` Chanwoo Choi
2016-03-31 9:06 ` [PATCH v7 16/20] ARM: dts: Add bus nodes using VDD_MIF for Exynos4210 Chanwoo Choi
2016-03-31 9:06 ` Chanwoo Choi
2016-03-31 9:06 ` [PATCH v7 17/20] ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes Chanwoo Choi
2016-03-31 9:06 ` Chanwoo Choi
2016-03-31 9:06 ` [PATCH v7 18/20] ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato Chanwoo Choi
2016-03-31 9:06 ` Chanwoo Choi
2016-03-31 9:06 ` [PATCH v7 19/20] ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3 Chanwoo Choi
2016-03-31 9:06 ` Chanwoo Choi
2016-03-31 9:06 ` [PATCH v7 20/20] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3 Chanwoo Choi
2016-03-31 9:06 ` Chanwoo Choi
2016-03-31 9:06 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD1E04.8050808@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vg \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=m.reichl@fivetechno.de \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.