From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c
Date: Thu, 31 Mar 2016 10:19:00 -0600 [thread overview]
Message-ID: <56FD4DF4.40004@redhat.com> (raw)
In-Reply-To: <1459429690-6144-1-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On 03/31/2016 07:08 AM, Daniel P. Berrange wrote:
> The netmap.c file fails to build on FreeBSD with
>
> net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
> error_setg_errno(errp, errno, "Failed to nm_open() %s",
> ^
> net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
> error_propagate(errp, err);
> ^
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> net/netmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c
Date: Thu, 31 Mar 2016 10:19:00 -0600 [thread overview]
Message-ID: <56FD4DF4.40004@redhat.com> (raw)
In-Reply-To: <1459429690-6144-1-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On 03/31/2016 07:08 AM, Daniel P. Berrange wrote:
> The netmap.c file fails to build on FreeBSD with
>
> net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
> error_setg_errno(errp, errno, "Failed to nm_open() %s",
> ^
> net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
> error_propagate(errp, err);
> ^
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> net/netmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-31 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:08 [Qemu-trivial] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c Daniel P. Berrange
2016-03-31 13:08 ` [Qemu-devel] " Daniel P. Berrange
2016-03-31 16:19 ` Eric Blake [this message]
2016-03-31 16:19 ` Eric Blake
2016-04-04 14:54 ` [Qemu-trivial] " Peter Maydell
2016-04-04 14:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD4DF4.40004@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.