From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jmaggard10@gmail.com
Subject: Re: [PATCH v2 3/3] ARM: dts: apq8064: add ahci ports-implemented mask
Date: Thu, 31 Mar 2016 23:25:38 +0300 [thread overview]
Message-ID: <56FD87C2.3020503@cogentembedded.com> (raw)
In-Reply-To: <1459445500-9071-4-git-send-email-srinivas.kandagatla@linaro.org>
On 03/31/2016 08:31 PM, Srinivas Kandagatla wrote:
> This patch adds new ports-implemented mask, which is required to get
> achi working on the mainline. Without this patch value read from
> PORTS_IMPL register which is zero would not enable any ports for
> software to use.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 252b310..71d6fcb 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -696,7 +696,7 @@
> };
>
> sata0: sata@29000000 {
> - compatible = "generic-ahci";
> + compatible = "generic-ahci", "qcom,apq8064-ahci";
The order of values should be reverse, no?
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: dts: apq8064: add ahci ports-implemented mask
Date: Thu, 31 Mar 2016 23:25:38 +0300 [thread overview]
Message-ID: <56FD87C2.3020503@cogentembedded.com> (raw)
In-Reply-To: <1459445500-9071-4-git-send-email-srinivas.kandagatla@linaro.org>
On 03/31/2016 08:31 PM, Srinivas Kandagatla wrote:
> This patch adds new ports-implemented mask, which is required to get
> achi working on the mainline. Without this patch value read from
> PORTS_IMPL register which is zero would not enable any ports for
> software to use.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 252b310..71d6fcb 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -696,7 +696,7 @@
> };
>
> sata0: sata at 29000000 {
> - compatible = "generic-ahci";
> + compatible = "generic-ahci", "qcom,apq8064-ahci";
The order of values should be reverse, no?
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-03-31 20:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 17:31 [PATCH v2 0/3] ahci: add ports-implemented dt bindings Srinivas Kandagatla
2016-03-31 17:31 ` Srinivas Kandagatla
2016-03-31 17:31 ` [PATCH v2 1/3] libahci: save port map for forced port map Srinivas Kandagatla
2016-03-31 17:31 ` Srinivas Kandagatla
2016-03-31 18:24 ` Andy Gross
2016-03-31 18:24 ` Andy Gross
2016-03-31 17:31 ` [PATCH v2 2/3] ata: ahci-platform: Add ports-implemented DT bindings Srinivas Kandagatla
2016-03-31 17:31 ` Srinivas Kandagatla
2016-03-31 17:34 ` Tejun Heo
2016-03-31 17:34 ` Tejun Heo
2016-03-31 18:23 ` Andy Gross
2016-03-31 18:23 ` Andy Gross
2016-03-31 17:31 ` [PATCH v2 3/3] ARM: dts: apq8064: add ahci ports-implemented mask Srinivas Kandagatla
2016-03-31 17:31 ` Srinivas Kandagatla
[not found] ` <1459445500-9071-4-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-31 18:20 ` Andy Gross
2016-03-31 18:20 ` Andy Gross
2016-03-31 18:20 ` Andy Gross
2016-03-31 20:25 ` Sergei Shtylyov [this message]
2016-03-31 20:25 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD87C2.3020503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jmaggard10@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.