All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, jeremy@goop.org, jdelvare@suse.com,
	konrad.wilk@oracle.com, hpa@zytor.com, akataria@vmware.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, chrisw@sous-sol.org,
	mingo@redhat.com, david.vrabel@citrix.com,
	Douglas_Warzecha@dell.com, pali.rohar@gmail.com,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
	tglx@linutronix.de, linux@roeck-us.net
Subject: Re: [PATCH v3 5/6] virt, sched: add cpu pinning to smp_call_sync_on_phys_cpu()
Date: Fri, 1 Apr 2016 11:26:25 +0200	[thread overview]
Message-ID: <56FE3EC1.7000800@suse.com> (raw)
In-Reply-To: <20160401091507.GG3448@twins.programming.kicks-ass.net>

On 01/04/16 11:15, Peter Zijlstra wrote:
> On Fri, Apr 01, 2016 at 11:03:21AM +0200, Juergen Gross wrote:
>>> Maybe just make the vpin thing an option like:
>>>
>>> 	smp_call_on_cpu(int (*func)(void *), int phys_cpu);
> 
>>> Also; is something like the vpin thing possible on KVM? because if we're
>>> going to expose it to generic code like this we had maybe look at wider
>>> support.
>>
>> It is necessary for dom0 under Xen. I don't think there is a need to do
>> this on KVM as a guest has no direct access to e.g. BIOS functions of
>> the real hardware and the host system needs no vcpu pinning. I'm not
>> sure about VMWare.
> 
> OK, then can we WARN if .phys=1 and the platform doesn't support it?
> 

Yes, good idea.


Juergen

WARNING: multiple messages have this Message-ID (diff)
From: Juergen Gross <jgross@suse.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
	david.vrabel@citrix.com, mingo@redhat.com,
	Douglas_Warzecha@dell.com, pali.rohar@gmail.com,
	jdelvare@suse.com, linux@roeck-us.net, tglx@linutronix.de,
	hpa@zytor.com, jeremy@goop.org, chrisw@sous-sol.org,
	akataria@vmware.com, rusty@rustcorp.com.au,
	virtualization@lists.linux-foundation.org, x86@kernel.org
Subject: Re: [PATCH v3 5/6] virt, sched: add cpu pinning to smp_call_sync_on_phys_cpu()
Date: Fri, 1 Apr 2016 11:26:25 +0200	[thread overview]
Message-ID: <56FE3EC1.7000800@suse.com> (raw)
In-Reply-To: <20160401091507.GG3448@twins.programming.kicks-ass.net>

On 01/04/16 11:15, Peter Zijlstra wrote:
> On Fri, Apr 01, 2016 at 11:03:21AM +0200, Juergen Gross wrote:
>>> Maybe just make the vpin thing an option like:
>>>
>>> 	smp_call_on_cpu(int (*func)(void *), int phys_cpu);
> 
>>> Also; is something like the vpin thing possible on KVM? because if we're
>>> going to expose it to generic code like this we had maybe look at wider
>>> support.
>>
>> It is necessary for dom0 under Xen. I don't think there is a need to do
>> this on KVM as a guest has no direct access to e.g. BIOS functions of
>> the real hardware and the host system needs no vcpu pinning. I'm not
>> sure about VMWare.
> 
> OK, then can we WARN if .phys=1 and the platform doesn't support it?
> 

Yes, good idea.


Juergen

  parent reply	other threads:[~2016-04-01  9:26 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01  7:14 [PATCH v3 0/6] Support calling functions on dedicated physical cpu Juergen Gross
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14 ` [PATCH v3 1/6] xen: sync xen header Juergen Gross
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14   ` Juergen Gross
2016-04-01  7:14 ` [PATCH v3 2/6] smp: add function to execute a function synchronously on a physical cpu Juergen Gross
2016-04-01  7:14   ` Juergen Gross
2016-04-01  7:37   ` Peter Zijlstra
2016-04-01  7:37     ` Peter Zijlstra
2016-04-01  7:40     ` Juergen Gross
2016-04-01  7:40       ` Juergen Gross
2016-04-01  7:40     ` Juergen Gross
2016-04-01  7:37   ` Peter Zijlstra
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14 ` [PATCH v3 3/6] dcdbas: make use of smp_call_sync_on_phys_cpu() Juergen Gross
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14 ` [PATCH v3 4/6] hwmon: use smp_call_sync_on_phys_cpu() for dell-smm i8k Juergen Gross
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14   ` Juergen Gross
2016-04-01  7:14 ` [PATCH v3 5/6] virt, sched: add cpu pinning to smp_call_sync_on_phys_cpu() Juergen Gross
2016-04-01  7:14   ` Juergen Gross
2016-04-01  7:43   ` Peter Zijlstra
2016-04-01  7:43     ` Peter Zijlstra
2016-04-01  8:28     ` Juergen Gross
2016-04-01  8:28     ` Juergen Gross
2016-04-01  8:28       ` Juergen Gross
2016-04-01  8:44       ` Peter Zijlstra
2016-04-01  8:44         ` Peter Zijlstra
2016-04-01  9:03         ` Juergen Gross
2016-04-01  9:03         ` Juergen Gross
2016-04-01  9:15           ` Peter Zijlstra
2016-04-01  9:15           ` Peter Zijlstra
2016-04-01  9:15             ` Peter Zijlstra
2016-04-01  9:26             ` Juergen Gross
2016-04-01  9:26             ` Juergen Gross [this message]
2016-04-01  9:26               ` Juergen Gross
2016-04-01  9:03         ` Juergen Gross
2016-04-01  8:44       ` Peter Zijlstra
2016-04-01  7:43   ` Peter Zijlstra
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14 ` [PATCH v3 6/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu Juergen Gross
2016-04-01  7:14 ` Juergen Gross
2016-04-01  7:14   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FE3EC1.7000800@suse.com \
    --to=jgross@suse.com \
    --cc=Douglas_Warzecha@dell.com \
    --cc=akataria@vmware.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=chrisw@sous-sol.org \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=pali.rohar@gmail.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.