From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>, zhaoshenglong@huawei.com
Cc: sstabellini@kernel.org, xen-devel@lists.xen.org,
peter.huangpeng@huawei.com, shannon.zhao@linaro.org
Subject: Re: [PATCH v2] xen/arm: use XENLOG_G_ERR instead
Date: Fri, 1 Apr 2016 15:36:31 +0100 [thread overview]
Message-ID: <56FE876F.5050306@arm.com> (raw)
In-Reply-To: <56FEA13902000078000E2220@prv-mh.provo.novell.com>
Hi,
On 01/04/16 15:26, Jan Beulich wrote:
>>>> On 31.03.16 at 11:41, <zhaoshenglong@huawei.com> wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> To distinguish the error logs in function map_dev_mmio_region, use
>> XENLOG_G_ERR instead of XENLOG_ERR.
>
> Both title and description are pretty strange.
You are right. Shannon, I would say:
"xen/arm: map_dev_mmio_region: printk should be ratelimited
The function map_dev_mmio_region is used in a hypercall. Therefore all
printks should be ratelimited to avoid a malicious guest flooding the
console."
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-01 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 9:41 [PATCH v2] xen/arm: use XENLOG_G_ERR instead Shannon Zhao
2016-04-01 14:12 ` Konrad Rzeszutek Wilk
2016-04-01 14:26 ` Jan Beulich
2016-04-01 14:36 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE876F.5050306@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.