* [PATCH v2] xen/arm: use XENLOG_G_ERR instead
@ 2016-03-31 9:41 Shannon Zhao
2016-04-01 14:12 ` Konrad Rzeszutek Wilk
2016-04-01 14:26 ` Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Shannon Zhao @ 2016-03-31 9:41 UTC (permalink / raw)
To: xen-devel
Cc: zhaoshenglong, julien.grall, sstabellini, shannon.zhao,
peter.huangpeng
From: Shannon Zhao <shannon.zhao@linaro.org>
To distinguish the error logs in function map_dev_mmio_region, use
XENLOG_G_ERR instead of XENLOG_ERR.
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
xen/arch/arm/p2m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 0011708..db21433 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1284,7 +1284,7 @@ int map_dev_mmio_region(struct domain *d,
res = map_mmio_regions(d, start_gfn, nr, mfn);
if ( res < 0 )
{
- printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
+ printk(XENLOG_G_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
start_gfn, start_gfn + nr - 1, d->domain_id);
return res;
}
--
2.0.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] xen/arm: use XENLOG_G_ERR instead
2016-03-31 9:41 [PATCH v2] xen/arm: use XENLOG_G_ERR instead Shannon Zhao
@ 2016-04-01 14:12 ` Konrad Rzeszutek Wilk
2016-04-01 14:26 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-04-01 14:12 UTC (permalink / raw)
To: Shannon Zhao
Cc: peter.huangpeng, julien.grall, sstabellini, shannon.zhao,
xen-devel
On Thu, Mar 31, 2016 at 05:41:49PM +0800, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> To distinguish the error logs in function map_dev_mmio_region, use
> XENLOG_G_ERR instead of XENLOG_ERR.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> xen/arch/arm/p2m.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 0011708..db21433 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1284,7 +1284,7 @@ int map_dev_mmio_region(struct domain *d,
> res = map_mmio_regions(d, start_gfn, nr, mfn);
> if ( res < 0 )
> {
> - printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
> + printk(XENLOG_G_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
> start_gfn, start_gfn + nr - 1, d->domain_id);
> return res;
> }
> --
> 2.0.4
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] xen/arm: use XENLOG_G_ERR instead
2016-03-31 9:41 [PATCH v2] xen/arm: use XENLOG_G_ERR instead Shannon Zhao
2016-04-01 14:12 ` Konrad Rzeszutek Wilk
@ 2016-04-01 14:26 ` Jan Beulich
2016-04-01 14:36 ` Julien Grall
1 sibling, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2016-04-01 14:26 UTC (permalink / raw)
To: zhaoshenglong
Cc: julien.grall, sstabellini, xen-devel, peter.huangpeng,
shannon.zhao
>>> On 31.03.16 at 11:41, <zhaoshenglong@huawei.com> wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> To distinguish the error logs in function map_dev_mmio_region, use
> XENLOG_G_ERR instead of XENLOG_ERR.
Both title and description are pretty strange.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] xen/arm: use XENLOG_G_ERR instead
2016-04-01 14:26 ` Jan Beulich
@ 2016-04-01 14:36 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2016-04-01 14:36 UTC (permalink / raw)
To: Jan Beulich, zhaoshenglong
Cc: sstabellini, xen-devel, peter.huangpeng, shannon.zhao
Hi,
On 01/04/16 15:26, Jan Beulich wrote:
>>>> On 31.03.16 at 11:41, <zhaoshenglong@huawei.com> wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> To distinguish the error logs in function map_dev_mmio_region, use
>> XENLOG_G_ERR instead of XENLOG_ERR.
>
> Both title and description are pretty strange.
You are right. Shannon, I would say:
"xen/arm: map_dev_mmio_region: printk should be ratelimited
The function map_dev_mmio_region is used in a hypercall. Therefore all
printks should be ratelimited to avoid a malicious guest flooding the
console."
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-01 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-31 9:41 [PATCH v2] xen/arm: use XENLOG_G_ERR instead Shannon Zhao
2016-04-01 14:12 ` Konrad Rzeszutek Wilk
2016-04-01 14:26 ` Jan Beulich
2016-04-01 14:36 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.