From: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250
Date: Fri, 1 Apr 2016 13:21:45 -0400 [thread overview]
Message-ID: <56FEAE29.6010405@osg.samsung.com> (raw)
In-Reply-To: <1459493874-2366-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Hello Krzysztof,
Patch looks good to me, I have just one question below:
On 04/01/2016 02:57 AM, Krzysztof Kozlowski wrote:
> Fix following DTC warnings in all Exynos5250 boards:
>
> Warning (unit_address_vs_reg): Node /dp-controller@145B0000/display-timings/timing@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /usb@12000000 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /usb@12000000/dwc3 has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /hdmi has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /mixer has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /video-phy@10040720 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator@1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator@2 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c@12C70000/trackpad has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c@12CD0000/lvds-bridge@20/ports/port@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c@12CD0000/lvds-bridge@20/ports/port@1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c@0/embedded-controller has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c@0/power-regulator has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c@12CA0000/embedded-controller has a reg or ranges property, but no unit name
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
[snip]
>
> - usb@12000000 {
> + usb_dwc3 {
> compatible = "samsung,exynos5250-dwusb3";
> clocks = <&clock CLK_USB3>;
> clock-names = "usbdrd30";
The ePAPR document says that "The name of a node should be somewhat generic,
reflecting the function of the device and not its precise programming model"
So I wonder if this shouldn't be instead:
usb_dwc3: usb {
Although it seems that not all DT bindings follow this convention so probably
the name in your patch is correct.
Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250
Date: Fri, 1 Apr 2016 13:21:45 -0400 [thread overview]
Message-ID: <56FEAE29.6010405@osg.samsung.com> (raw)
In-Reply-To: <1459493874-2366-6-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
Patch looks good to me, I have just one question below:
On 04/01/2016 02:57 AM, Krzysztof Kozlowski wrote:
> Fix following DTC warnings in all Exynos5250 boards:
>
> Warning (unit_address_vs_reg): Node /dp-controller at 145B0000/display-timings/timing at 0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /usb at 12000000 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /usb at 12000000/dwc3 has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /hdmi has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /mixer has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /video-phy at 10040720 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator at 0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator at 1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator at 2 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c at 12C70000/trackpad has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c at 12CD0000/lvds-bridge at 20/ports/port at 0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c at 12CD0000/lvds-bridge at 20/ports/port at 1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c at 0/embedded-controller has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c at 0/power-regulator has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c at 12CA0000/embedded-controller has a reg or ranges property, but no unit name
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
[snip]
>
> - usb at 12000000 {
> + usb_dwc3 {
> compatible = "samsung,exynos5250-dwusb3";
> clocks = <&clock CLK_USB3>;
> clock-names = "usbdrd30";
The ePAPR document says that "The name of a node should be somewhat generic,
reflecting the function of the device and not its precise programming model"
So I wonder if this shouldn't be instead:
usb_dwc3: usb {
Although it seems that not all DT bindings follow this convention so probably
the name in your patch is correct.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250
Date: Fri, 1 Apr 2016 13:21:45 -0400 [thread overview]
Message-ID: <56FEAE29.6010405@osg.samsung.com> (raw)
In-Reply-To: <1459493874-2366-6-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
Patch looks good to me, I have just one question below:
On 04/01/2016 02:57 AM, Krzysztof Kozlowski wrote:
> Fix following DTC warnings in all Exynos5250 boards:
>
> Warning (unit_address_vs_reg): Node /dp-controller@145B0000/display-timings/timing@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /usb@12000000 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /usb@12000000/dwc3 has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /hdmi has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /mixer has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /video-phy@10040720 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator@1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /fixed-regulator@2 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c@12C70000/trackpad has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c@12CD0000/lvds-bridge@20/ports/port@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c@12CD0000/lvds-bridge@20/ports/port@1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c@0/embedded-controller has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c@0/power-regulator has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c@12CA0000/embedded-controller has a reg or ranges property, but no unit name
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
[snip]
>
> - usb@12000000 {
> + usb_dwc3 {
> compatible = "samsung,exynos5250-dwusb3";
> clocks = <&clock CLK_USB3>;
> clock-names = "usbdrd30";
The ePAPR document says that "The name of a node should be somewhat generic,
reflecting the function of the device and not its precise programming model"
So I wonder if this shouldn't be instead:
usb_dwc3: usb {
Although it seems that not all DT bindings follow this convention so probably
the name in your patch is correct.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-04-01 17:21 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 6:57 [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 6:57 ` [PATCH 02/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos3250 Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
[not found] ` <1459493874-2366-2-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-04-01 14:27 ` Javier Martinez Canillas
2016-04-01 14:27 ` Javier Martinez Canillas
2016-04-01 14:27 ` Javier Martinez Canillas
2016-04-01 6:57 ` [PATCH 03/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos4 Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 14:30 ` Javier Martinez Canillas
2016-04-01 14:30 ` Javier Martinez Canillas
2016-04-01 6:57 ` [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in Trats2 board Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 8:17 ` Krzysztof Kozlowski
2016-04-01 8:17 ` Krzysztof Kozlowski
2016-04-01 14:35 ` Javier Martinez Canillas
2016-04-01 14:35 ` Javier Martinez Canillas
2016-04-01 6:57 ` [PATCH 05/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos4x12 Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 14:38 ` Javier Martinez Canillas
2016-04-01 14:38 ` Javier Martinez Canillas
2016-04-01 6:57 ` [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250 Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
[not found] ` <1459493874-2366-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-04-01 17:21 ` Javier Martinez Canillas [this message]
2016-04-01 17:21 ` Javier Martinez Canillas
2016-04-01 17:21 ` Javier Martinez Canillas
2016-04-03 2:56 ` Krzysztof Kozlowski
2016-04-03 2:56 ` Krzysztof Kozlowski
[not found] ` <56FEAE29.6010405-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-04-03 2:56 ` Krzysztof Kozlowski
2016-04-03 4:08 ` Krzysztof Kozlowski
2016-04-03 4:08 ` Krzysztof Kozlowski
2016-04-01 6:57 ` [PATCH 07/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos542x Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
[not found] ` <1459493874-2366-7-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-04-01 17:25 ` Javier Martinez Canillas
2016-04-01 17:25 ` Javier Martinez Canillas
2016-04-01 17:25 ` Javier Martinez Canillas
2016-04-01 6:57 ` [PATCH 08/11] ARM: dts: exynos: Fix DTC unit name warnings in Peach Pit Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 17:27 ` Javier Martinez Canillas
2016-04-01 17:27 ` Javier Martinez Canillas
[not found] ` <1459493874-2366-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-04-01 6:57 ` [PATCH 09/11] ARM: dts: exynos: Fix DTC unit name warnings in SMDK5420 Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 17:30 ` Javier Martinez Canillas
2016-04-01 17:30 ` Javier Martinez Canillas
2016-04-01 6:57 ` [PATCH 10/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5440 Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
2016-04-01 17:46 ` Javier Martinez Canillas
2016-04-01 17:46 ` Javier Martinez Canillas
2016-04-01 6:57 ` [PATCH 11/11] ARM: dts: s5p: Fix DTC unit name warnings in S5Pv210 boards Krzysztof Kozlowski
2016-04-01 6:57 ` Krzysztof Kozlowski
[not found] ` <1459493874-2366-11-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-04-01 17:50 ` Javier Martinez Canillas
2016-04-01 17:50 ` Javier Martinez Canillas
2016-04-01 17:50 ` Javier Martinez Canillas
2016-04-01 14:24 ` [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Javier Martinez Canillas
2016-04-01 14:24 ` Javier Martinez Canillas
2016-04-01 15:31 ` Rob Herring
2016-04-01 15:31 ` Rob Herring
2016-04-03 3:46 ` Krzysztof Kozlowski
2016-04-03 3:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FEAE29.6010405@osg.samsung.com \
--to=javier-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.