All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Braunegg" <alex.braunegg@gmail.com>
To: 'Ian Campbell' <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: 'Ian Jackson' <Ian.Jackson@eu.citrix.com>,
	'Wei Liu' <wei.liu2@citrix.com>,
	'Jan Beulich' <JBeulich@suse.com>,
	'Andrew Cooper' <Andrew.Cooper3@citrix.com>
Subject: Re: [BUG} libxl.c:5947:libxl_send_trigger: Send trigger 'reset' failed: Function not implemented
Date: Thu, 11 Feb 2016 09:30:26 +1100	[thread overview]
Message-ID: <56bbba08.ee35420a.d8138.fffff636@mx.google.com> (raw)
In-Reply-To: <1455096752.19857.114.camel@citrix.com>

Hi Ian,

> There is a function internal to libxl (libxl__domain_pvcontrol) which
> answers this question (by looking at the callback IRQ).

I looked at this function yesterday and it appears that it calls:

	ret = libxl__domain_pvcontrol_available(gc, domid);

which in turn calls:

	ret = xc_hvm_param_get(ctx->xch, domid, HVM_PARAM_CALLBACK_IRQ, &pvdriver);

which is defined in xenctrl.h, this is why I thought it may have been easier to call "xc_hvm_param_get" directly inside the 'xl vm-list' function with the applicable header applied.

> I suppose it would be reasonable to expose that formally in the libxl
> public API in some form, although it is also the case that any function
> which uses PV control mechanisms performs (or at least should perform) this
> check and return ERROR_NOPARAVIRT if pv control is not avaiable, so
> application code can try PV and fallback to other methods (as xl does).

> libxc (xenctrl.h) is not a stable interface and it is a design goal of
> libxl that toolstacks should only need to use libxl interfaces for their
> toolstack oriented operations. So this functionality would need to be
> reflected in the stable libxl API for use by xl (and libvirt, and other
> toolstacks people might write)

So potentially before trying to make use of libxl__domain_pvcontrol for the 'xl vm-list' command to provide feedback if PV control is available, I will need to wait for the functionality to be exposed via an applicable libxl header.

Best regards,

Alex

  reply	other threads:[~2016-02-10 22:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 21:50 [BUG} libxl.c:5947:libxl_send_trigger: Send trigger 'reset' failed: Function not implemented Alex Braunegg
2016-02-04 10:57 ` Ian Campbell
2016-02-04 23:08   ` Alex Braunegg
2016-02-09 10:28     ` Ian Campbell
2016-02-10  0:51       ` Alex Braunegg
2016-02-10  9:32         ` Ian Campbell
2016-02-10 22:30           ` Alex Braunegg [this message]
2016-02-11  9:33             ` Ian Campbell
2016-02-08 21:48   ` Alex Braunegg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56bbba08.ee35420a.d8138.fffff636@mx.google.com \
    --to=alex.braunegg@gmail.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.