* [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error
@ 2025-11-06 18:05 Lizhi Hou
2025-11-06 18:12 ` Mario Limonciello
2025-11-13 16:53 ` Falkowski, Maciej
0 siblings, 2 replies; 6+ messages in thread
From: Lizhi Hou @ 2025-11-06 18:05 UTC (permalink / raw)
To: ogabbay, quic_jhugo, maciej.falkowski, dri-devel
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan,
mario.limonciello
Failing to set power off indicates an unrecoverable hardware or firmware
error. Update the driver to treat such a failure as a fatal condition
and stop further operations that depend on successful power state
transition.
This prevents undefined behavior when the hardware remains in an
unexpected state after a failed power-off attempt.
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/aie2_smu.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/accel/amdxdna/aie2_smu.c b/drivers/accel/amdxdna/aie2_smu.c
index 11c0e9e7b03a..bd94ee96c2bc 100644
--- a/drivers/accel/amdxdna/aie2_smu.c
+++ b/drivers/accel/amdxdna/aie2_smu.c
@@ -147,6 +147,16 @@ int aie2_smu_init(struct amdxdna_dev_hdl *ndev)
{
int ret;
+ /*
+ * Failing to set power off indicates an unrecoverable hardware or
+ * firmware error.
+ */
+ ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
+ if (ret) {
+ XDNA_ERR(ndev->xdna, "Access power failed, ret %d", ret);
+ return ret;
+ }
+
ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_ON, 0, NULL);
if (ret) {
XDNA_ERR(ndev->xdna, "Power on failed, ret %d", ret);
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error
2025-11-06 18:05 [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error Lizhi Hou
@ 2025-11-06 18:12 ` Mario Limonciello
2025-11-06 18:19 ` Lizhi Hou
2025-11-13 16:53 ` Falkowski, Maciej
1 sibling, 1 reply; 6+ messages in thread
From: Mario Limonciello @ 2025-11-06 18:12 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, maciej.falkowski, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan
On 11/6/25 12:05 PM, Lizhi Hou wrote:
> Failing to set power off indicates an unrecoverable hardware or firmware
> error. Update the driver to treat such a failure as a fatal condition
> and stop further operations that depend on successful power state
> transition.
>
> This prevents undefined behavior when the hardware remains in an
> unexpected state after a failed power-off attempt.
>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Presumably all versions of hardware in the wild can handle receiving a
power off command if they're already powered off?
> ---
> drivers/accel/amdxdna/aie2_smu.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/accel/amdxdna/aie2_smu.c b/drivers/accel/amdxdna/aie2_smu.c
> index 11c0e9e7b03a..bd94ee96c2bc 100644
> --- a/drivers/accel/amdxdna/aie2_smu.c
> +++ b/drivers/accel/amdxdna/aie2_smu.c
> @@ -147,6 +147,16 @@ int aie2_smu_init(struct amdxdna_dev_hdl *ndev)
> {
> int ret;
>
> + /*
> + * Failing to set power off indicates an unrecoverable hardware or
> + * firmware error.
> + */
> + ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
> + if (ret) {
> + XDNA_ERR(ndev->xdna, "Access power failed, ret %d", ret);
> + return ret;
> + }
> +
> ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_ON, 0, NULL);
> if (ret) {
> XDNA_ERR(ndev->xdna, "Power on failed, ret %d", ret);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error
2025-11-06 18:12 ` Mario Limonciello
@ 2025-11-06 18:19 ` Lizhi Hou
2025-11-06 18:31 ` Mario Limonciello
0 siblings, 1 reply; 6+ messages in thread
From: Lizhi Hou @ 2025-11-06 18:19 UTC (permalink / raw)
To: Mario Limonciello, ogabbay, quic_jhugo, maciej.falkowski,
dri-devel
Cc: linux-kernel, max.zhen, sonal.santan
On 11/6/25 10:12, Mario Limonciello wrote:
> On 11/6/25 12:05 PM, Lizhi Hou wrote:
>> Failing to set power off indicates an unrecoverable hardware or firmware
>> error. Update the driver to treat such a failure as a fatal condition
>> and stop further operations that depend on successful power state
>> transition.
>>
>> This prevents undefined behavior when the hardware remains in an
>> unexpected state after a failed power-off attempt.
>>
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>
> Presumably all versions of hardware in the wild can handle receiving a
> power off command if they're already powered off?
Yes for the aie2 platforms. This was verified by xdna-driver pipeline tests.
Lizhi
>
>> ---
>> drivers/accel/amdxdna/aie2_smu.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_smu.c
>> b/drivers/accel/amdxdna/aie2_smu.c
>> index 11c0e9e7b03a..bd94ee96c2bc 100644
>> --- a/drivers/accel/amdxdna/aie2_smu.c
>> +++ b/drivers/accel/amdxdna/aie2_smu.c
>> @@ -147,6 +147,16 @@ int aie2_smu_init(struct amdxdna_dev_hdl *ndev)
>> {
>> int ret;
>> + /*
>> + * Failing to set power off indicates an unrecoverable hardware or
>> + * firmware error.
>> + */
>> + ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
>> + if (ret) {
>> + XDNA_ERR(ndev->xdna, "Access power failed, ret %d", ret);
>> + return ret;
>> + }
>> +
>> ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_ON, 0, NULL);
>> if (ret) {
>> XDNA_ERR(ndev->xdna, "Power on failed, ret %d", ret);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error
2025-11-06 18:19 ` Lizhi Hou
@ 2025-11-06 18:31 ` Mario Limonciello
2025-11-07 16:57 ` Lizhi Hou
0 siblings, 1 reply; 6+ messages in thread
From: Mario Limonciello @ 2025-11-06 18:31 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, maciej.falkowski, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan
On 11/6/25 12:19 PM, Lizhi Hou wrote:
>
> On 11/6/25 10:12, Mario Limonciello wrote:
>> On 11/6/25 12:05 PM, Lizhi Hou wrote:
>>> Failing to set power off indicates an unrecoverable hardware or firmware
>>> error. Update the driver to treat such a failure as a fatal condition
>>> and stop further operations that depend on successful power state
>>> transition.
>>>
>>> This prevents undefined behavior when the hardware remains in an
>>> unexpected state after a failed power-off attempt.
>>>
>>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>>
>> Presumably all versions of hardware in the wild can handle receiving a
>> power off command if they're already powered off?
>
> Yes for the aie2 platforms. This was verified by xdna-driver pipeline
> tests.
>
>
OK LGTM then.
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> Lizhi
>
>>
>>> ---
>>> drivers/accel/amdxdna/aie2_smu.c | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/drivers/accel/amdxdna/aie2_smu.c b/drivers/accel/
>>> amdxdna/aie2_smu.c
>>> index 11c0e9e7b03a..bd94ee96c2bc 100644
>>> --- a/drivers/accel/amdxdna/aie2_smu.c
>>> +++ b/drivers/accel/amdxdna/aie2_smu.c
>>> @@ -147,6 +147,16 @@ int aie2_smu_init(struct amdxdna_dev_hdl *ndev)
>>> {
>>> int ret;
>>> + /*
>>> + * Failing to set power off indicates an unrecoverable hardware or
>>> + * firmware error.
>>> + */
>>> + ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
>>> + if (ret) {
>>> + XDNA_ERR(ndev->xdna, "Access power failed, ret %d", ret);
>>> + return ret;
>>> + }
>>> +
>>> ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_ON, 0, NULL);
>>> if (ret) {
>>> XDNA_ERR(ndev->xdna, "Power on failed, ret %d", ret);
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error
2025-11-06 18:31 ` Mario Limonciello
@ 2025-11-07 16:57 ` Lizhi Hou
0 siblings, 0 replies; 6+ messages in thread
From: Lizhi Hou @ 2025-11-07 16:57 UTC (permalink / raw)
To: Mario Limonciello, ogabbay, quic_jhugo, maciej.falkowski,
dri-devel
Cc: linux-kernel, max.zhen, sonal.santan
Applied to drm-misc-next.
On 11/6/25 10:31, Mario Limonciello wrote:
> On 11/6/25 12:19 PM, Lizhi Hou wrote:
>>
>> On 11/6/25 10:12, Mario Limonciello wrote:
>>> On 11/6/25 12:05 PM, Lizhi Hou wrote:
>>>> Failing to set power off indicates an unrecoverable hardware or
>>>> firmware
>>>> error. Update the driver to treat such a failure as a fatal condition
>>>> and stop further operations that depend on successful power state
>>>> transition.
>>>>
>>>> This prevents undefined behavior when the hardware remains in an
>>>> unexpected state after a failed power-off attempt.
>>>>
>>>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>>>
>>> Presumably all versions of hardware in the wild can handle receiving
>>> a power off command if they're already powered off?
>>
>> Yes for the aie2 platforms. This was verified by xdna-driver pipeline
>> tests.
>>
>>
>
> OK LGTM then.
>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>
>> Lizhi
>>
>>>
>>>> ---
>>>> drivers/accel/amdxdna/aie2_smu.c | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/drivers/accel/amdxdna/aie2_smu.c b/drivers/accel/
>>>> amdxdna/aie2_smu.c
>>>> index 11c0e9e7b03a..bd94ee96c2bc 100644
>>>> --- a/drivers/accel/amdxdna/aie2_smu.c
>>>> +++ b/drivers/accel/amdxdna/aie2_smu.c
>>>> @@ -147,6 +147,16 @@ int aie2_smu_init(struct amdxdna_dev_hdl *ndev)
>>>> {
>>>> int ret;
>>>> + /*
>>>> + * Failing to set power off indicates an unrecoverable
>>>> hardware or
>>>> + * firmware error.
>>>> + */
>>>> + ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
>>>> + if (ret) {
>>>> + XDNA_ERR(ndev->xdna, "Access power failed, ret %d", ret);
>>>> + return ret;
>>>> + }
>>>> +
>>>> ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_ON, 0, NULL);
>>>> if (ret) {
>>>> XDNA_ERR(ndev->xdna, "Power on failed, ret %d", ret);
>>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error
2025-11-06 18:05 [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error Lizhi Hou
2025-11-06 18:12 ` Mario Limonciello
@ 2025-11-13 16:53 ` Falkowski, Maciej
1 sibling, 0 replies; 6+ messages in thread
From: Falkowski, Maciej @ 2025-11-13 16:53 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan, mario.limonciello
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 11/6/2025 7:05 PM, Lizhi Hou wrote:
> Failing to set power off indicates an unrecoverable hardware or firmware
> error. Update the driver to treat such a failure as a fatal condition
> and stop further operations that depend on successful power state
> transition.
>
> This prevents undefined behavior when the hardware remains in an
> unexpected state after a failed power-off attempt.
>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
> drivers/accel/amdxdna/aie2_smu.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/accel/amdxdna/aie2_smu.c b/drivers/accel/amdxdna/aie2_smu.c
> index 11c0e9e7b03a..bd94ee96c2bc 100644
> --- a/drivers/accel/amdxdna/aie2_smu.c
> +++ b/drivers/accel/amdxdna/aie2_smu.c
> @@ -147,6 +147,16 @@ int aie2_smu_init(struct amdxdna_dev_hdl *ndev)
> {
> int ret;
>
> + /*
> + * Failing to set power off indicates an unrecoverable hardware or
> + * firmware error.
> + */
> + ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
> + if (ret) {
> + XDNA_ERR(ndev->xdna, "Access power failed, ret %d", ret);
> + return ret;
> + }
> +
> ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_ON, 0, NULL);
> if (ret) {
> XDNA_ERR(ndev->xdna, "Power on failed, ret %d", ret);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-11-13 16:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-06 18:05 [PATCH] accel/amdxdna: Treat power-off failure as unrecoverable error Lizhi Hou
2025-11-06 18:12 ` Mario Limonciello
2025-11-06 18:19 ` Lizhi Hou
2025-11-06 18:31 ` Mario Limonciello
2025-11-07 16:57 ` Lizhi Hou
2025-11-13 16:53 ` Falkowski, Maciej
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.