* [PATCH] staging: vme: fix bare use of 'unsigned'
@ 2016-03-31 22:53 ` Clifton Barnes
0 siblings, 0 replies; 6+ messages in thread
From: Clifton Barnes @ 2016-03-31 22:53 UTC (permalink / raw)
To: martyn, manohar.vanga, gregkh
Cc: kernel-janitors, linux-kernel, devel, Clifton Barnes
fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
'unsigned''
Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
---
drivers/staging/vme/devices/vme_pio2_gpio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
index df992c3..f52a9ed 100644
--- a/drivers/staging/vme/devices/vme_pio2_gpio.c
+++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
@@ -97,7 +97,7 @@ static void pio2_gpio_set(struct gpio_chip *chip,
}
/* Directionality configured at board build - send appropriate response */
-static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
+static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset)
{
int data;
struct pio2_card *card = gpio_to_pio2_card(chip);
@@ -116,7 +116,8 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
}
/* Directionality configured at board build - send appropriate response */
-static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value)
+static int pio2_gpio_dir_out(struct gpio_chip *chip,
+ unsigned int offset, int value)
{
int data;
struct pio2_card *card = gpio_to_pio2_card(chip);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] staging: vme: fix bare use of 'unsigned'
@ 2016-03-31 22:53 ` Clifton Barnes
0 siblings, 0 replies; 6+ messages in thread
From: Clifton Barnes @ 2016-03-31 22:53 UTC (permalink / raw)
To: martyn, manohar.vanga, gregkh
Cc: kernel-janitors, linux-kernel, devel, Clifton Barnes
fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
'unsigned''
Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
---
drivers/staging/vme/devices/vme_pio2_gpio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
index df992c3..f52a9ed 100644
--- a/drivers/staging/vme/devices/vme_pio2_gpio.c
+++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
@@ -97,7 +97,7 @@ static void pio2_gpio_set(struct gpio_chip *chip,
}
/* Directionality configured at board build - send appropriate response */
-static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
+static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset)
{
int data;
struct pio2_card *card = gpio_to_pio2_card(chip);
@@ -116,7 +116,8 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
}
/* Directionality configured at board build - send appropriate response */
-static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value)
+static int pio2_gpio_dir_out(struct gpio_chip *chip,
+ unsigned int offset, int value)
{
int data;
struct pio2_card *card = gpio_to_pio2_card(chip);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: vme: fix bare use of 'unsigned'
2016-03-31 22:53 ` Clifton Barnes
@ 2016-04-03 20:36 ` Martyn Welch
-1 siblings, 0 replies; 6+ messages in thread
From: Martyn Welch @ 2016-04-03 20:36 UTC (permalink / raw)
To: Clifton Barnes, martyn, manohar.vanga, gregkh
Cc: kernel-janitors, linux-kernel, devel
On 31/03/16 23:53, Clifton Barnes wrote:
> fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
> 'unsigned''
>
> Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
Acked-by: Martyn Welch <martyn@welchs.me.uk>
Greg: Whilst this patch seems valid and compiles fine, I no longer have
access to the hardware for this driver. I'm aware this driver has been
in the staging tree for a rather long time. I will check to see if
there's any intention for further work to be done on this driver, if not
I guess we should be looking to delete it from the staging tree.
Martyn
> ---
> drivers/staging/vme/devices/vme_pio2_gpio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
> index df992c3..f52a9ed 100644
> --- a/drivers/staging/vme/devices/vme_pio2_gpio.c
> +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
> @@ -97,7 +97,7 @@ static void pio2_gpio_set(struct gpio_chip *chip,
> }
>
> /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> +static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset)
> {
> int data;
> struct pio2_card *card = gpio_to_pio2_card(chip);
> @@ -116,7 +116,8 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> }
>
> /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value)
> +static int pio2_gpio_dir_out(struct gpio_chip *chip,
> + unsigned int offset, int value)
> {
> int data;
> struct pio2_card *card = gpio_to_pio2_card(chip);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: vme: fix bare use of 'unsigned'
@ 2016-04-03 20:36 ` Martyn Welch
0 siblings, 0 replies; 6+ messages in thread
From: Martyn Welch @ 2016-04-03 20:36 UTC (permalink / raw)
To: Clifton Barnes, martyn, manohar.vanga, gregkh
Cc: kernel-janitors, linux-kernel, devel
On 31/03/16 23:53, Clifton Barnes wrote:
> fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
> 'unsigned''
>
> Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
Acked-by: Martyn Welch <martyn@welchs.me.uk>
Greg: Whilst this patch seems valid and compiles fine, I no longer have
access to the hardware for this driver. I'm aware this driver has been
in the staging tree for a rather long time. I will check to see if
there's any intention for further work to be done on this driver, if not
I guess we should be looking to delete it from the staging tree.
Martyn
> ---
> drivers/staging/vme/devices/vme_pio2_gpio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
> index df992c3..f52a9ed 100644
> --- a/drivers/staging/vme/devices/vme_pio2_gpio.c
> +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
> @@ -97,7 +97,7 @@ static void pio2_gpio_set(struct gpio_chip *chip,
> }
>
> /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> +static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset)
> {
> int data;
> struct pio2_card *card = gpio_to_pio2_card(chip);
> @@ -116,7 +116,8 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> }
>
> /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value)
> +static int pio2_gpio_dir_out(struct gpio_chip *chip,
> + unsigned int offset, int value)
> {
> int data;
> struct pio2_card *card = gpio_to_pio2_card(chip);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: vme: fix bare use of 'unsigned'
2016-04-03 20:36 ` Martyn Welch
@ 2016-04-04 19:26 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2016-04-04 19:26 UTC (permalink / raw)
To: Martyn Welch
Cc: Clifton Barnes, martyn, manohar.vanga, kernel-janitors,
linux-kernel, devel
On Sun, Apr 03, 2016 at 09:36:31PM +0100, Martyn Welch wrote:
>
>
> On 31/03/16 23:53, Clifton Barnes wrote:
> > fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
> > 'unsigned''
> >
> > Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
>
> Acked-by: Martyn Welch <martyn@welchs.me.uk>
>
> Greg: Whilst this patch seems valid and compiles fine, I no longer have
> access to the hardware for this driver. I'm aware this driver has been in
> the staging tree for a rather long time. I will check to see if there's any
> intention for further work to be done on this driver, if not I guess we
> should be looking to delete it from the staging tree.
>
Thanks, let me know if you want it deleted.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: vme: fix bare use of 'unsigned'
@ 2016-04-04 19:26 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2016-04-04 19:26 UTC (permalink / raw)
To: Martyn Welch
Cc: Clifton Barnes, martyn, manohar.vanga, kernel-janitors,
linux-kernel, devel
On Sun, Apr 03, 2016 at 09:36:31PM +0100, Martyn Welch wrote:
>
>
> On 31/03/16 23:53, Clifton Barnes wrote:
> > fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
> > 'unsigned''
> >
> > Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
>
> Acked-by: Martyn Welch <martyn@welchs.me.uk>
>
> Greg: Whilst this patch seems valid and compiles fine, I no longer have
> access to the hardware for this driver. I'm aware this driver has been in
> the staging tree for a rather long time. I will check to see if there's any
> intention for further work to be done on this driver, if not I guess we
> should be looking to delete it from the staging tree.
>
Thanks, let me know if you want it deleted.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-04 19:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-31 22:53 [PATCH] staging: vme: fix bare use of 'unsigned' Clifton Barnes
2016-03-31 22:53 ` Clifton Barnes
2016-04-03 20:36 ` Martyn Welch
2016-04-03 20:36 ` Martyn Welch
2016-04-04 19:26 ` Greg KH
2016-04-04 19:26 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.