[PATCH] ARM: dts: exynos-5422-odroid: Remove always_on for eMMC and SD regulators

[PATCH] ARM: dts: exynos-5422-odroid: Remove always_on for eMMC and SD regulators

[Markus Reichl]

Allow these suplies to be switched off if not used.

Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
---
Tested with eMMC only on XU4.
SD still needs testing.
---
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index a761d3f..6f2f364 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -141,7 +141,6 @@
                                regulator-name = "vddq_mmc0";
                                regulator-min-microvolt = <1800000>;
                                regulator-max-microvolt = <1800000>;
-                               regulator-always-on;
                        };
 
                        ldo5_reg: LDO5 {
@@ -204,7 +203,6 @@
                                regulator-name = "vddq_mmc2";
                                regulator-min-microvolt = <2800000>;
                                regulator-max-microvolt = <2800000>;
-                               regulator-always-on;
                        };
 
                        ldo15_reg: LDO15 {
@@ -232,14 +230,12 @@
                                regulator-name = "vdd_emmc_1V8";
                                regulator-min-microvolt = <1800000>;
                                regulator-max-microvolt = <1800000>;
-                               regulator-always-on;
                        };
 
                        ldo19_reg: LDO19 {
                                regulator-name = "vdd_sd";
                                regulator-min-microvolt = <2800000>;
                                regulator-max-microvolt = <2800000>;
-                               regulator-always-on;
                        };
 
                        ldo24_reg: LDO24 {
-- 
2.1.4

Re: [PATCH] ARM: dts: exynos-5422-odroid: Remove always_on for eMMC and SD regulators

[Krzysztof Kozlowski]

On 01.04.2016 23:45, Markus Reichl wrote:
> Allow these suplies to be switched off if not used.

s/suplies/supplies/

> 
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> Tested with eMMC only on XU4.
> SD still needs testing.

I wanted to test your patches but the first does not apply
(next-20160401, my for-next) so I gave up.

I think this patch should be squashed with previous one. I don't see
benefits of splitting this (but maybe I am missing something?).

Best regards,
Krzysztof

Re: [PATCH] ARM: dts: exynos-5422-odroid: Remove always_on for eMMC and SD regulators

[Markus Reichl]

Hi Krzysztof,  

Am 04.04.2016 um 02:37 schrieb Krzysztof Kozlowski:
> On 01.04.2016 23:45, Markus Reichl wrote:
>> Allow these suplies to be switched off if not used.
> 
> s/suplies/supplies/

Will correct it.

> 
>>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>> ---
>> Tested with eMMC only on XU4.
>> SD still needs testing.
> 
> I wanted to test your patches but the first does not apply
> (next-20160401, my for-next) so I gave up.

Will check and base on next-20160401.

> 
> I think this patch should be squashed with previous one. I don't see
> benefits of splitting this (but maybe I am missing something?).

Will sqash them into one.

> 
> Best regards,
> Krzysztof
> 
Servus,
--
Markus Reichl