* [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice
@ 2016-04-01 20:17 Thadeu Lima de Souza Cascardo
2016-04-04 7:51 ` Nicolas Dichtel
2016-04-05 23:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2016-04-01 20:17 UTC (permalink / raw)
To: netdev
When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set
before ip6_tnl_create2 is called. When register_netdevice is called, there
is no linkinfo attribute in the NEWLINK message because of that.
Setting rtnl_link_ops before calling register_netdevice fixes that.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
---
net/ipv6/ip6_tunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index eb2ac4b..1f20345 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -252,12 +252,12 @@ static int ip6_tnl_create2(struct net_device *dev)
t = netdev_priv(dev);
+ dev->rtnl_link_ops = &ip6_link_ops;
err = register_netdevice(dev);
if (err < 0)
goto out;
strcpy(t->parms.name, dev->name);
- dev->rtnl_link_ops = &ip6_link_ops;
dev_hold(dev);
ip6_tnl_link(ip6n, t);
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice
2016-04-01 20:17 [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice Thadeu Lima de Souza Cascardo
@ 2016-04-04 7:51 ` Nicolas Dichtel
2016-04-05 23:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2016-04-04 7:51 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo, netdev
Le 01/04/2016 22:17, Thadeu Lima de Souza Cascardo a écrit :
> When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set
> before ip6_tnl_create2 is called. When register_netdevice is called, there
> is no linkinfo attribute in the NEWLINK message because of that.
>
> Setting rtnl_link_ops before calling register_netdevice fixes that.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Fixes: 0b112457229d ("ip6tnl: add support of link creation via rtnl")
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice
2016-04-01 20:17 [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice Thadeu Lima de Souza Cascardo
2016-04-04 7:51 ` Nicolas Dichtel
@ 2016-04-05 23:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-04-05 23:49 UTC (permalink / raw)
To: cascardo; +Cc: netdev
From: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Date: Fri, 1 Apr 2016 17:17:50 -0300
> When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set
> before ip6_tnl_create2 is called. When register_netdevice is called, there
> is no linkinfo attribute in the NEWLINK message because of that.
>
> Setting rtnl_link_ops before calling register_netdevice fixes that.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-05 23:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-01 20:17 [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice Thadeu Lima de Souza Cascardo
2016-04-04 7:51 ` Nicolas Dichtel
2016-04-05 23:49 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.