All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Ming Lin <mlin@kernel.org>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS
Date: Mon, 4 Apr 2016 07:22:03 -0700	[thread overview]
Message-ID: <5702788B.7000509@sandisk.com> (raw)
In-Reply-To: <1458684196-15923-5-git-send-email-mlin@kernel.org>

On 03/22/16 15:03, Ming Lin wrote:
> From: Ming Lin <ming.l@ssi.samsung.com>
>
> Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount
> we fit into a single scatterlist chunk.
>
> Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS.
>
> Will move these 2 generic definitions to scatterlist.h later.
>
> Signed-off-by: Ming Lin <ming.l@ssi.samsung.com>
> ---
>   drivers/ata/pata_icside.c           |  2 +-
>   drivers/infiniband/ulp/srp/ib_srp.c |  4 ++--
>   drivers/scsi/arm/cumana_2.c         |  2 +-
>   drivers/scsi/arm/eesox.c            |  2 +-
>   drivers/scsi/arm/powertec.c         |  2 +-
>   drivers/scsi/esas2r/esas2r_main.c   |  4 ++--
>   drivers/scsi/hisi_sas/hisi_sas.h    |  2 +-
>   drivers/scsi/mpt3sas/mpt3sas_base.c |  4 ++--
>   drivers/scsi/mpt3sas/mpt3sas_base.h |  2 +-
>   drivers/scsi/scsi_debug.c           |  2 +-
>   drivers/scsi/scsi_lib.c             | 34 +++++++++++++++++-----------------
>   drivers/usb/storage/scsiglue.c      |  2 +-
>   include/scsi/scsi.h                 |  8 ++++----
>   include/scsi/scsi_host.h            |  2 +-
>   14 files changed, 36 insertions(+), 36 deletions(-)

Hello Ming,

The ib_srp changes in this patch look fine to me.

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Ming Lin <mlin@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-scsi@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS
Date: Mon, 4 Apr 2016 07:22:03 -0700	[thread overview]
Message-ID: <5702788B.7000509@sandisk.com> (raw)
In-Reply-To: <1458684196-15923-5-git-send-email-mlin@kernel.org>

On 03/22/16 15:03, Ming Lin wrote:
> From: Ming Lin <ming.l@ssi.samsung.com>
>
> Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount
> we fit into a single scatterlist chunk.
>
> Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS.
>
> Will move these 2 generic definitions to scatterlist.h later.
>
> Signed-off-by: Ming Lin <ming.l@ssi.samsung.com>
> ---
>   drivers/ata/pata_icside.c           |  2 +-
>   drivers/infiniband/ulp/srp/ib_srp.c |  4 ++--
>   drivers/scsi/arm/cumana_2.c         |  2 +-
>   drivers/scsi/arm/eesox.c            |  2 +-
>   drivers/scsi/arm/powertec.c         |  2 +-
>   drivers/scsi/esas2r/esas2r_main.c   |  4 ++--
>   drivers/scsi/hisi_sas/hisi_sas.h    |  2 +-
>   drivers/scsi/mpt3sas/mpt3sas_base.c |  4 ++--
>   drivers/scsi/mpt3sas/mpt3sas_base.h |  2 +-
>   drivers/scsi/scsi_debug.c           |  2 +-
>   drivers/scsi/scsi_lib.c             | 34 +++++++++++++++++-----------------
>   drivers/usb/storage/scsiglue.c      |  2 +-
>   include/scsi/scsi.h                 |  8 ++++----
>   include/scsi/scsi_host.h            |  2 +-
>   14 files changed, 36 insertions(+), 36 deletions(-)

Hello Ming,

The ib_srp changes in this patch look fine to me.

Bart.

  reply	other threads:[~2016-04-04 14:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 22:03 [PATCH v2 0/5] mempool based chained scatterlist alloc/free api Ming Lin
2016-03-22 22:03 ` [PATCH v2 1/5] scsi: replace "scsi_data_buffer" with "sg_table" in SG functions Ming Lin
2016-03-22 22:03 ` [PATCH v2 2/5] scsi: replace "mq" with "first_chunk" " Ming Lin
2016-03-22 22:03 ` [PATCH v2 3/5] scsi: rename SG related struct and functions Ming Lin
2016-03-22 22:03 ` [PATCH v2 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS Ming Lin
2016-04-04 14:22   ` Bart Van Assche [this message]
2016-04-04 14:22     ` Bart Van Assche
2016-04-04 20:24   ` Ming Lin
2016-04-04 21:22     ` Tejun Heo
2016-03-22 22:03 ` [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c Ming Lin
2016-03-23  2:38   ` [PATCH] lib: scatterlist: fix ifnullfree.cocci warnings kbuild test robot
2016-03-23  2:38   ` [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c kbuild test robot
2016-04-04 20:15     ` Ming Lin
2016-04-04 20:17       ` Christoph Hellwig
2016-04-04 20:29         ` Ming Lin
2016-03-23  7:40 ` [PATCH v2 0/5] mempool based chained scatterlist alloc/free api Christoph Hellwig
2016-03-24 15:09   ` Ming Lin
2016-03-24 15:09     ` Ming Lin
2016-03-24 15:46     ` James Bottomley
2016-03-24 15:46       ` James Bottomley
2016-03-28 14:48       ` Ming Lin
2016-04-04  6:07         ` Ming Lin
2016-04-04 14:01           ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5702788B.7000509@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mlin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.