All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Stefan Weil <sw@weilnetz.de>,
	Sergey Fedorov <sergey.fedorov@linaro.org>,
	 qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [PATCH] tci: Fix build with no '-DNDEBUG'
Date: Mon, 4 Apr 2016 21:06:37 +0300	[thread overview]
Message-ID: <5702AD2D.8050406@gmail.com> (raw)
In-Reply-To: <5702AA32.507@weilnetz.de>

On 04/04/16 20:53, Stefan Weil wrote:
> Am 04.04.2016 um 15:22 schrieb Sergey Fedorov:
>> On 04/04/16 14:56, Stefan Weil wrote:
> [...]
>>> There is indeed a regression in the current code. Commit
>>> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement
>>> which includes assert.h before NDEBUG is defined. This is wrong and
>>> needs a fix. Could you please try tci.c starting like this?
>>>
>>> /* Defining NDEBUG disables assertions (which makes the code faster). */
>>> #if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
>>> # define NDEBUG
>>> #endif
>>>
>>> #include "qemu/osdep.h"
>>>
>> Doing so really helps. So what are the plans of how to fix the problem?
>>
>> Thanks,
>> Sergey
>
> The correct fix needs a little bit more code because my first try (see
> above) did not get the definition of macro CONFIG_DEBUG_TCG.
>
> My patch was now sent to the list.

Thanks!


WARNING: multiple messages have this Message-ID (diff)
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Stefan Weil <sw@weilnetz.de>,
	Sergey Fedorov <sergey.fedorov@linaro.org>,
	qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] tci: Fix build with no '-DNDEBUG'
Date: Mon, 4 Apr 2016 21:06:37 +0300	[thread overview]
Message-ID: <5702AD2D.8050406@gmail.com> (raw)
In-Reply-To: <5702AA32.507@weilnetz.de>

On 04/04/16 20:53, Stefan Weil wrote:
> Am 04.04.2016 um 15:22 schrieb Sergey Fedorov:
>> On 04/04/16 14:56, Stefan Weil wrote:
> [...]
>>> There is indeed a regression in the current code. Commit
>>> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement
>>> which includes assert.h before NDEBUG is defined. This is wrong and
>>> needs a fix. Could you please try tci.c starting like this?
>>>
>>> /* Defining NDEBUG disables assertions (which makes the code faster). */
>>> #if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
>>> # define NDEBUG
>>> #endif
>>>
>>> #include "qemu/osdep.h"
>>>
>> Doing so really helps. So what are the plans of how to fix the problem?
>>
>> Thanks,
>> Sergey
>
> The correct fix needs a little bit more code because my first try (see
> above) did not get the definition of macro CONFIG_DEBUG_TCG.
>
> My patch was now sent to the list.

Thanks!

  reply	other threads:[~2016-04-04 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 11:05 [Qemu-trivial] [PATCH] tci: Fix build with no '-DNDEBUG' Sergey Fedorov
2016-04-04 11:05 ` [Qemu-devel] " Sergey Fedorov
2016-04-04 11:56 ` [Qemu-trivial] " Stefan Weil
2016-04-04 11:56   ` [Qemu-devel] " Stefan Weil
2016-04-04 13:22   ` [Qemu-trivial] " Sergey Fedorov
2016-04-04 13:22     ` [Qemu-devel] " Sergey Fedorov
2016-04-04 17:53     ` [Qemu-trivial] " Stefan Weil
2016-04-04 17:53       ` [Qemu-devel] " Stefan Weil
2016-04-04 18:06       ` Sergey Fedorov [this message]
2016-04-04 18:06         ` Sergey Fedorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5702AD2D.8050406@gmail.com \
    --to=serge.fdrv@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sergey.fedorov@linaro.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.