All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki.Poulose@arm.com (Suzuki K. Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call
Date: Tue, 5 Apr 2016 10:26:50 +0100	[thread overview]
Message-ID: <570384DA.6010805@arm.com> (raw)
In-Reply-To: <1459766569-17237-1-git-send-email-anna-maria@linutronix.de>

On 04/04/16 11:42, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call of
> hw_breakpoint_reset(). To keep the calling convention, interrupts are
> explicitely disabled around the call.

While you are at it, could you please also fix a similar instance
in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ?

Thanks
Suzuki

WARNING: multiple messages have this Message-ID (diff)
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>,
	linux-kernel@vger.kernel.org
Cc: rt@linutronix.de, Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call
Date: Tue, 5 Apr 2016 10:26:50 +0100	[thread overview]
Message-ID: <570384DA.6010805@arm.com> (raw)
In-Reply-To: <1459766569-17237-1-git-send-email-anna-maria@linutronix.de>

On 04/04/16 11:42, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call of
> hw_breakpoint_reset(). To keep the calling convention, interrupts are
> explicitely disabled around the call.

While you are at it, could you please also fix a similar instance
in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ?

Thanks
Suzuki

  parent reply	other threads:[~2016-04-05  9:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 10:42 [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call Anna-Maria Gleixner
2016-04-04 10:42 ` Anna-Maria Gleixner
2016-04-04 14:06 ` Sergei Shtylyov
2016-04-04 14:06   ` Sergei Shtylyov
2016-04-05  9:26 ` Suzuki K. Poulose [this message]
2016-04-05  9:26   ` Suzuki K. Poulose
2016-04-05  9:39   ` Anna-Maria Gleixner
2016-04-05  9:39     ` Anna-Maria Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570384DA.6010805@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.