All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 10/15] doc/memory: update MMIO section
Date: Tue, 5 Apr 2016 17:59:58 +0800	[thread overview]
Message-ID: <57038C9E.30405@cn.fujitsu.com> (raw)
In-Reply-To: <1459849818-26649-11-git-send-email-pbonzini@redhat.com>



On 04/05/2016 05:50 PM, Paolo Bonzini wrote:
> From: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> There is no memory_region_io(). And remove a stray '-'.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> Message-Id: <1459507677-16662-1-git-send-email-caoj.fnst@cn.fujitsu.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   docs/memory.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 97134e1..f9272ca 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -37,8 +37,8 @@ MemoryRegion):
>
>   - MMIO: a range of guest memory that is implemented by host callbacks;
>     each read or write causes a callback to be called on the host.
> -  You initialize these with memory_region_io(), passing it a MemoryRegionOps
> -  structure describing the callbacks.
> +  You initialize these with memory_region_init_io(), passing it a
> +  MemoryRegionOps structure describing the callbacks.
>
>   - ROM: a ROM memory region works like RAM for reads (directly accessing
>     a region of host memory), but like MMIO for writes (invoking a callback).
>

Hi Paolo,
    Seems the patch ignore the slight modification on that memory 
figure, So commit message isn`t consistent with the patch content. And 
actually I missed to remove a space between 7000 and 8000, since I 
removed a "-"

-- 
Yours Sincerely,

Cao jin

  reply	other threads:[~2016-04-05  9:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05  9:50 [Qemu-devel] [PULL 00/15] Misc changes for QEMU 2.6.0-rc1 Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 01/15] update Linux headers to 4.6 Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 02/15] target-i386/kvm: Hyper-V VMBus hypercalls blank handlers Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 03/15] memory: fix segv on qemu_ram_free(block=0x0) Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 04/15] target-i386: do not pass MSR_TSC_AUX to KVM ioctls if CPUID bit is not set Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 05/15] target-i386: assert that KVM_GET/SET_MSRS can set all requested MSRs Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 06/15] checkpatch: add target_ulong to typelist Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 07/15] util: retry getaddrinfo if getting EAI_BADFLAGS with AI_V4MAPPED Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 08/15] char: fix broken EAGAIN retry on OS-X due to errno clobbering Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 09/15] char: ensure all clients are in non-blocking mode Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 10/15] doc/memory: update MMIO section Paolo Bonzini
2016-04-05  9:59   ` Cao jin [this message]
2016-04-05 10:19     ` Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 11/15] nbd: don't request FUA on FLUSH Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 12/15] cpus: don't use atomic_read for vm_clock_warp_start Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 13/15] include/qemu/atomic: add compile time asserts Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 14/15] nbd: Fix poor debug message Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 15/15] net: fix missing include of qapi/error.h in netmap.c Paolo Bonzini
2016-04-05 10:53 ` [Qemu-devel] [PULL 00/15] Misc changes for QEMU 2.6.0-rc1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57038C9E.30405@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.