From: Eric Blake <eblake@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
qemu trivial <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Alex Bennee <alex.bennee@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
John Snow <jsnow@redhat.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [Qemu-trivial] [PATCH] tests: ignore test-logging
Date: Tue, 5 Apr 2016 10:44:27 -0600 [thread overview]
Message-ID: <5703EB6B.1050705@redhat.com> (raw)
In-Reply-To: <57036822.9070501@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On 04/05/2016 01:24 AM, Changlong Xie wrote:
> On 04/05/2016 02:35 PM, Changlong Xie wrote:
>> Commit 3514552e added a new test, but did not mark it for
>> exclusion in .gitignore.
>>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>> tests/.gitignore | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/.gitignore b/tests/.gitignore
>> index b7bf13e..898a35f 100644
>> --- a/tests/.gitignore
>> +++ b/tests/.gitignore
>> @@ -70,5 +70,6 @@ test-xbzrle
>> test-netfilter
>> test-filter-mirror
>> test-filter-redirector
>> +test-logging
>> *-test
>> qapi-schema/*.test.*
>>
> It seems we should keep items in order, so
>
> From a6d9e3aeaee66941613ebed312ee7a1b0e80bcc3 Mon Sep 17 00:00:00 2001
> From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Date: Thu, 31 Mar 2016 13:52:35 +0800
> Subject: [PATCH] tests: ignore test-logging
>
> Commit 3514552e added a new test, but did not mark it for
> exclusion in .gitignore.
May be easier to resend this as a top-level v2 (or now v3), so that it
is easier for a maintainer to pick up. But in any case, your v2 is:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
qemu trivial <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Alex Bennee <alex.bennee@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests: ignore test-logging
Date: Tue, 5 Apr 2016 10:44:27 -0600 [thread overview]
Message-ID: <5703EB6B.1050705@redhat.com> (raw)
In-Reply-To: <57036822.9070501@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On 04/05/2016 01:24 AM, Changlong Xie wrote:
> On 04/05/2016 02:35 PM, Changlong Xie wrote:
>> Commit 3514552e added a new test, but did not mark it for
>> exclusion in .gitignore.
>>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>> tests/.gitignore | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/.gitignore b/tests/.gitignore
>> index b7bf13e..898a35f 100644
>> --- a/tests/.gitignore
>> +++ b/tests/.gitignore
>> @@ -70,5 +70,6 @@ test-xbzrle
>> test-netfilter
>> test-filter-mirror
>> test-filter-redirector
>> +test-logging
>> *-test
>> qapi-schema/*.test.*
>>
> It seems we should keep items in order, so
>
> From a6d9e3aeaee66941613ebed312ee7a1b0e80bcc3 Mon Sep 17 00:00:00 2001
> From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Date: Thu, 31 Mar 2016 13:52:35 +0800
> Subject: [PATCH] tests: ignore test-logging
>
> Commit 3514552e added a new test, but did not mark it for
> exclusion in .gitignore.
May be easier to resend this as a top-level v2 (or now v3), so that it
is easier for a maintainer to pick up. But in any case, your v2 is:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-04-05 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 6:35 [Qemu-trivial] [PATCH] tests: ignore test-logging Changlong Xie
2016-04-05 6:35 ` [Qemu-devel] " Changlong Xie
2016-04-05 7:24 ` [Qemu-trivial] " Changlong Xie
2016-04-05 7:24 ` [Qemu-devel] " Changlong Xie
2016-04-05 16:44 ` Eric Blake [this message]
2016-04-05 16:44 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703EB6B.1050705@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wency@cn.fujitsu.com \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.