From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Jiangang <weijg.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
mjt@tls.msk.ru, avi@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] docs: fix typo in memory.txt
Date: Wed, 6 Apr 2016 01:02:14 +0200 [thread overview]
Message-ID: <570443F6.5010603@redhat.com> (raw)
In-Reply-To: <1458639954-9980-1-git-send-email-weijg.fnst@cn.fujitsu.com>
On 22/03/2016 10:45, Wei Jiangang wrote:
> The scale line should align with A line's end,
No, A ends at 0x7fff so the line should end just before. See what
happens for B/C/D/E.
However, the space between 7000 and 8000 is indede 7 characters instead
of 6, so I will take your patch and also reduce the space between A's
brackets.
Thanks,
Paolo
> and correct the range of vga-window example 0xa0000-0xbffff.
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> docs/memory.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 97134e1..5a7163c 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two
> of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
> offset 0x2000. As a diagram:
>
> - 0 1000 2000 3000 4000 5000 6000 7000 8000
> - |------|------|------|------|------|------|------|-------|
> + 0 1000 2000 3000 4000 5000 6000 7000 8000
> + |------|------|------|------|------|------|------|------|
> A: [ ]
> C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
> B: [ ]
> @@ -247,7 +247,7 @@ system_memory: container@0-2^48-1
> |
> +---- himem: alias@0x100000000-0x11fffffff ---> #ram (0xe0000000-0xffffffff)
> |
> - +---- vga-window: alias@0xa0000-0xbfffff ---> #pci (0xa0000-0xbffff)
> + +---- vga-window: alias@0xa0000-0xbffff ---> #pci (0xa0000-0xbffff)
> | (prio 1)
> |
> +---- pci-hole: alias@0xe0000000-0xffffffff ---> #pci (0xe0000000-0xffffffff)
>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Jiangang <weijg.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
mjt@tls.msk.ru, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH] docs: fix typo in memory.txt
Date: Wed, 6 Apr 2016 01:02:14 +0200 [thread overview]
Message-ID: <570443F6.5010603@redhat.com> (raw)
In-Reply-To: <1458639954-9980-1-git-send-email-weijg.fnst@cn.fujitsu.com>
On 22/03/2016 10:45, Wei Jiangang wrote:
> The scale line should align with A line's end,
No, A ends at 0x7fff so the line should end just before. See what
happens for B/C/D/E.
However, the space between 7000 and 8000 is indede 7 characters instead
of 6, so I will take your patch and also reduce the space between A's
brackets.
Thanks,
Paolo
> and correct the range of vga-window example 0xa0000-0xbffff.
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> docs/memory.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 97134e1..5a7163c 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two
> of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
> offset 0x2000. As a diagram:
>
> - 0 1000 2000 3000 4000 5000 6000 7000 8000
> - |------|------|------|------|------|------|------|-------|
> + 0 1000 2000 3000 4000 5000 6000 7000 8000
> + |------|------|------|------|------|------|------|------|
> A: [ ]
> C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
> B: [ ]
> @@ -247,7 +247,7 @@ system_memory: container@0-2^48-1
> |
> +---- himem: alias@0x100000000-0x11fffffff ---> #ram (0xe0000000-0xffffffff)
> |
> - +---- vga-window: alias@0xa0000-0xbfffff ---> #pci (0xa0000-0xbffff)
> + +---- vga-window: alias@0xa0000-0xbffff ---> #pci (0xa0000-0xbffff)
> | (prio 1)
> |
> +---- pci-hole: alias@0xe0000000-0xffffffff ---> #pci (0xe0000000-0xffffffff)
>
next prev parent reply other threads:[~2016-04-05 23:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 9:45 [Qemu-trivial] [Qemu-devel][PATCH] docs: fix typo in memory.txt Wei Jiangang
2016-03-22 9:45 ` [Qemu-devel] [PATCH] " Wei Jiangang
2016-04-05 1:01 ` [Qemu-trivial] [Qemu-devel][PATCH] " Wei, Jiangang
2016-04-05 1:01 ` [Qemu-devel] [PATCH] " Wei, Jiangang
2016-04-05 23:02 ` Paolo Bonzini [this message]
2016-04-05 23:02 ` Paolo Bonzini
2016-04-06 1:12 ` [Qemu-trivial] " Wei, Jiangang
2016-04-06 1:12 ` [Qemu-devel] " Wei, Jiangang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570443F6.5010603@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=weijg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.