Re: [meta-fsl-arm][PATCH] gstreamer1.0-plugins-imx: Update to version 0.12.1

[Carlos Rafael Giani <dv@pseudoterminal.org>]

On 2016-04-06 10:43, Gary Bisson wrote:

> -# gstreamer1.0-plugins-bad is in DEPENDS because imxv4l2videosrc
> requires
> -# the GstPhotography headers and libraries
> -DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base
> gstreamer1.0-plugins-bad imx-gpu-viv \
> -           libfslcodec libimxvpuapi virtual/kernel virtual/egl
> virtual/libgles2 \
> -           ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11',
> '', d)}"
> +# gstreamer1.0-plugins-bad is in DEPENDS because the build script scans
> for the
> +# GstPhotography headers and libraries
> +DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base
> gstreamer1.0-plugins-bad virtual/kernel"
>>> Shouldn't plugins-bad be a dependency for v4l2src only?
>>
>> The configuration switches only switch on/off the actual plugins (and their
>> immediate dependencies, like GLES libraries, or libimxvpuapi).
>> And, gstphotography is a dependency-less component of -bad. In the -bad
>> tree, gstphotography can be found in gst-libs/ , while stuff that has
>> external dependencies is in ext/.
>> What this means is that gstphotography is *not* enabled/disabled by the
>> v4l2src switch in the build script. This is intentional - dependency-less
>> GStreamer *libraries* might be used by more than one gstreamer-imx plugin in
>> the future, which is why they are autoconfigured in the root build script.
>> (For example, gstreamer-video-1.0 is used by the vpu plugins as well as the
>> ipu and pxp ones.)
>> If I put -bad as a v4l2src dependency, then the build script would still
>> scan for gstphotography if you turn off the v4l2src plugin. bitbake would
>> then print a warning that -bad is a dependency but is not part of the
>> DEPENDS list.
> Ok, I didn't know the plugin would throw a warning on that dependency,
> we don't want a warning for sure.
> What confused me is the comment since it clearly states that
> plugins-bad is for imxv4l2videosrc.

True, this could be confusing. This is why I changed the comment ;-)

> Here is what I think it should look like:
> PACKAGECONFIG_mx6q = "eglvivsink g2d ipu mp3encoder pxp uniaudiocodec
> v4l2src vpu"
> PACKAGECONFIG_mx6dl = "eglvivsink g2d ipu mp3encoder pxp uniaudiocodec
> v4l2src vpu"
> PACKAGECONFIG_mx6sx = "eglvivsink g2d mp3encoder pxp uniaudiocodec v4l2src"
> PACKAGECONFIG_mx6sl = "g2d mp3encoder pxp uniaudiocodec v4l2src"
> PACKAGECONFIG_mx7 = "mp3encoder pxp uniaudiocodec v4l2src"
>
> I've ordered the flags alphabetically, feel free to change it.
>
> Regards,
> Gary

Thanks, this helps. (uniaudiodec, not uniaudiocodec, but I'll rename 
that in the v2 recipe.)
Also, if anybody can try this on older SoCs such as an imx5, I would 
welcome patches, both for the recipe and for gstreamer-imx itself :-)

Carlos