From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Ander Conselvan De Oliveira <conselvan2@gmail.com>,
intel-gfx@lists.freedesktop.org,
Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
Subject: Re: ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Splitting intel_dp_detect
Date: Wed, 6 Apr 2016 15:38:02 +0100 [thread overview]
Message-ID: <57051F4A.9060204@linux.intel.com> (raw)
In-Reply-To: <570252DC.5070701@linux.intel.com>
On 04/04/16 12:41, Tvrtko Ursulin wrote:
>
> On 04/04/16 12:08, Jani Nikula wrote:
>> On Mon, 04 Apr 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> wrote:
>>> On 01/04/16 08:41, Ander Conselvan De Oliveira wrote:
>>>> On Thu, 2016-03-31 at 12:38 +0000, Patchwork wrote:
>>>>> == Series Details ==
>>>>>
>>>>> Series: series starting with [1/5] drm/i915: Splitting intel_dp_detect
>>>>> URL : https://patchwork.freedesktop.org/series/5044/
>>>>> State : success
>>>>
>>>> I pushed those to dinq.
>>>
>>> This series seems to break eDP detection on BDW RVP.
>>
>> I presume this is due to the sink count check. Can you add debug logging
>> to print intel_dp->sink_count after it's been read in
>> intel_dp_get_dpcd() please?
>
> intel_dp->sink_count is zero here. (raw value, before the
> DP_GET_SINK_COUNT.)
>
> Also, intel_dp_dpcd_read_wake suggests a possibility for reading garbage
> with not overly confident wording for the workaround there.
>
>> Then the question is, is this just because you have an RVP with who
>> knows what panel, or do we have to take into account potentially broken
>> panels too? Then I assume the fix would be to to ignore sink count for
>> eDP.
>
> No idea. :)
I could really use a solution for this. My only development platform is
incapacitated unless I revert this series which, apart from the extra
work when preparing and sending out patches this is taking, including
lost time waiting on CI which I suspect dislikes patches from top of
unknown bases, I think it won't be so easy to continue doing so when the
conflicts start arriving. :(
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-06 14:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 12:35 [PATCH 1/5] drm/i915: Splitting intel_dp_detect Shubhangi Shrivastava
2016-03-30 12:35 ` [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse Shubhangi Shrivastava
2016-03-30 12:35 ` [PATCH 3/5] drm/i915: Reorganizing intel_dp_check_link_status Shubhangi Shrivastava
2016-03-30 12:35 ` [PATCH 4/5] drm/i915: Read sink_count dpcd always Shubhangi Shrivastava
2016-03-30 12:35 ` [PATCH 5/5] drm/i915: force full detect on sink count change Shubhangi Shrivastava
2016-03-31 12:38 ` ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Splitting intel_dp_detect Patchwork
2016-04-01 7:41 ` Ander Conselvan De Oliveira
2016-04-04 10:31 ` Tvrtko Ursulin
2016-04-04 11:08 ` Jani Nikula
2016-04-04 11:41 ` Tvrtko Ursulin
2016-04-06 14:38 ` Tvrtko Ursulin [this message]
2016-04-07 7:58 ` Jani Nikula
2016-04-07 8:24 ` Ander Conselvan De Oliveira
2016-04-07 9:56 ` Thulasimani, Sivakumar
2016-04-07 10:12 ` Shubhangi Shrivastava
2016-04-07 10:00 ` Tvrtko Ursulin
2016-04-07 10:56 ` Joonas Lahtinen
2016-04-04 11:07 ` Shubhangi Shrivastava
-- strict thread matches above, loose matches on Subject: below --
2016-02-01 11:42 [PATCH 1/5] " Shubhangi Shrivastava
2016-02-01 12:15 ` ✓ Fi.CI.BAT: success for series starting with [1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57051F4A.9060204@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=shubhangi.shrivastava@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.