From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Vinod Koul <vinod.koul@intel.com>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Gross <andy.gross@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,
Pramod Gurav <gpramod@codeaurora.org>
Subject: Re: [PATCH v2 5/5] dmaengine: qcom: bam_dma: rename BAM_MAX_DATA_SIZE define
Date: Wed, 6 Apr 2016 18:30:11 +0300 [thread overview]
Message-ID: <57052B83.4000208@linaro.org> (raw)
In-Reply-To: <20160405234739.GF11586@vkoul-mobl.iind.intel.com>
On 04/06/2016 02:47 AM, Vinod Koul wrote:
> On Wed, Apr 06, 2016 at 01:56:22AM +0300, Stanimir Varbanov wrote:
>> It seems that the define has not been with acurate name and
>> makes confusion while reading the code. The more acurate
>> name should be BAM_FIFO_SIZE.
>
> And not sure by that, what do you mean by FIFO size. In dmaengine context we
By BAM_FIFO_SIZE I meant a FIFO depth for hw descriptors, i.e. how many
hw descriptors could be pushed into the descriptor FIFO. In our case we
wrote BAM_P_FIFO_SIZES register with SZ_32K - 8, which means that the
FIFO will be 4095 hw descriptors deep.
In fact the important patch in this series 4/5 where I corrected the
value we wrote in BAM_P_FIFO_SIZES register.
4/5 and 5/5 can be postponed till we have better decision...
--
regards,
Stan
WARNING: multiple messages have this Message-ID (diff)
From: stanimir.varbanov@linaro.org (Stanimir Varbanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] dmaengine: qcom: bam_dma: rename BAM_MAX_DATA_SIZE define
Date: Wed, 6 Apr 2016 18:30:11 +0300 [thread overview]
Message-ID: <57052B83.4000208@linaro.org> (raw)
In-Reply-To: <20160405234739.GF11586@vkoul-mobl.iind.intel.com>
On 04/06/2016 02:47 AM, Vinod Koul wrote:
> On Wed, Apr 06, 2016 at 01:56:22AM +0300, Stanimir Varbanov wrote:
>> It seems that the define has not been with acurate name and
>> makes confusion while reading the code. The more acurate
>> name should be BAM_FIFO_SIZE.
>
> And not sure by that, what do you mean by FIFO size. In dmaengine context we
By BAM_FIFO_SIZE I meant a FIFO depth for hw descriptors, i.e. how many
hw descriptors could be pushed into the descriptor FIFO. In our case we
wrote BAM_P_FIFO_SIZES register with SZ_32K - 8, which means that the
FIFO will be 4095 hw descriptors deep.
In fact the important patch in this series 4/5 where I corrected the
value we wrote in BAM_P_FIFO_SIZES register.
4/5 and 5/5 can be postponed till we have better decision...
--
regards,
Stan
next prev parent reply other threads:[~2016-04-06 15:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 22:56 [PATCH v2 0/5] bam dma fixes and one dt extension Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
2016-04-05 22:56 ` [PATCH v2 1/5] dmaengine: qcom: bam_dma: fix dma free memory on remove Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
2016-04-05 22:56 ` [PATCH v2 2/5] dmaengine: qcom: bam_dma: clear BAM interrupt only if it is rised Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
2016-04-05 23:41 ` Vinod Koul
2016-04-05 23:41 ` Vinod Koul
2016-04-11 7:51 ` gpramod
2016-04-11 7:51 ` gpramod at codeaurora.org
2016-04-05 22:56 ` [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
2016-04-05 23:44 ` Vinod Koul
2016-04-05 23:44 ` Vinod Koul
2016-04-06 6:05 ` Andy Gross
2016-04-06 6:05 ` Andy Gross
2016-04-06 15:05 ` Stanimir Varbanov
2016-04-06 15:05 ` Stanimir Varbanov
2016-04-07 17:57 ` Rob Herring
2016-04-07 17:57 ` Rob Herring
2016-04-07 17:57 ` Rob Herring
2016-04-11 7:53 ` gpramod
2016-04-11 7:53 ` gpramod at codeaurora.org
2016-04-05 22:56 ` [PATCH v2 4/5] dmaengine: qcom: bam_dma: use correct pipe FIFO size Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
[not found] ` <1459896982-30171-5-git-send-email-stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-05 23:45 ` Vinod Koul
2016-04-05 23:45 ` Vinod Koul
2016-04-05 23:45 ` Vinod Koul
2016-04-05 22:56 ` [PATCH v2 5/5] dmaengine: qcom: bam_dma: rename BAM_MAX_DATA_SIZE define Stanimir Varbanov
2016-04-05 22:56 ` Stanimir Varbanov
2016-04-05 23:47 ` Vinod Koul
2016-04-05 23:47 ` Vinod Koul
2016-04-06 15:30 ` Stanimir Varbanov [this message]
2016-04-06 15:30 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57052B83.4000208@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gpramod@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=okaya@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.