From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: fix naming in GPIO DT binding header
Date: Wed, 6 Apr 2016 11:32:13 -0600 [thread overview]
Message-ID: <5705481D.3030700@wwwdotorg.org> (raw)
In-Reply-To: <20160406172845.GC28843-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
On 04/06/2016 11:28 AM, Thierry Reding wrote:
> On Tue, Apr 05, 2016 at 01:25:07PM -0600, Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> According to the Tegra TRM, GPIOs are aggregated into /ports/ of 8 GPIOs,
>> not into /banks/. Fix <dt-bindings/gpio/tegra-gpio.h> to correctly reflect
>> this naming convention. While this seems like silly churn, it will become
>> slightly more important once we introduce the GPIO binding for upcoming
>> Tegra chips.
>>
>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> include/dt-bindings/gpio/tegra-gpio.h | 68 +++++++++++++++++------------------
>> 1 file changed, 34 insertions(+), 34 deletions(-)
>
> It's not clear to me where this should be applied. This is technically
> part of the GPIO controller bindings, in which case it'd need to go via
> the GPIO tree. I'm fine with taking it through the Tegra tree, too, but
> in case you agree that it should go through the GPIO tree:
>
> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
I typically consider bindings part of the SoC code-base they related to,
so I'd imagine this going through the Tegra tree. I didn't Cc LinusW on
the patch because of that thinking and oversight, but have done so now
just in case he feels strongly.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: fix naming in GPIO DT binding header
Date: Wed, 6 Apr 2016 11:32:13 -0600 [thread overview]
Message-ID: <5705481D.3030700@wwwdotorg.org> (raw)
In-Reply-To: <20160406172845.GC28843@ulmo.ba.sec>
On 04/06/2016 11:28 AM, Thierry Reding wrote:
> On Tue, Apr 05, 2016 at 01:25:07PM -0600, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> According to the Tegra TRM, GPIOs are aggregated into /ports/ of 8 GPIOs,
>> not into /banks/. Fix <dt-bindings/gpio/tegra-gpio.h> to correctly reflect
>> this naming convention. While this seems like silly churn, it will become
>> slightly more important once we introduce the GPIO binding for upcoming
>> Tegra chips.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> include/dt-bindings/gpio/tegra-gpio.h | 68 +++++++++++++++++------------------
>> 1 file changed, 34 insertions(+), 34 deletions(-)
>
> It's not clear to me where this should be applied. This is technically
> part of the GPIO controller bindings, in which case it'd need to go via
> the GPIO tree. I'm fine with taking it through the Tegra tree, too, but
> in case you agree that it should go through the GPIO tree:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
I typically consider bindings part of the SoC code-base they related to,
so I'd imagine this going through the Tegra tree. I didn't Cc LinusW on
the patch because of that thinking and oversight, but have done so now
just in case he feels strongly.
next prev parent reply other threads:[~2016-04-06 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 19:25 [PATCH] ARM: tegra: fix naming in GPIO DT binding header Stephen Warren
2016-04-05 19:25 ` Stephen Warren
[not found] ` <1459884307-24043-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-06 17:28 ` Thierry Reding
2016-04-06 17:28 ` Thierry Reding
[not found] ` <20160406172845.GC28843-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-04-06 17:32 ` Stephen Warren [this message]
2016-04-06 17:32 ` Stephen Warren
[not found] ` <5705481D.3030700-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-11 7:04 ` Linus Walleij
2016-04-11 7:04 ` Linus Walleij
[not found] ` <CACRpkdZxeV07_rb2xL+HRGp-ay1B-U=_tEbPCYqvM+ZYD-wpYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-22 11:24 ` Thierry Reding
2016-04-22 11:24 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5705481D.3030700@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.