All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: iSER initiator in 4.5 is unhappy..
Date: Thu, 7 Apr 2016 10:14:17 +0300	[thread overview]
Message-ID: <570608C9.1070805@grimberg.me> (raw)
In-Reply-To: <20160406231658.GB11588-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>


>> So this scatterlist seems perfectly fine (no gaps). The only thing I
>> can think of is that we don't have enough space reserved, but I counted
>> 127 pages in the scatterlist when iser reserves 128 (by default).
>>
>> Just in case I mis-counted, can you (or Max) try with the below
>> patch:
>
> This works fine for me, but I wonder if the miscounting is in the
> block layer?

We communicate the "max_pages" via sg_tablesize and max_hw_sectors.

iSER communicates (or at least supposed to) sg_tablesize=128 and
max_sectors=1024 to scsi (which sets the block queues attributes), that
should be sufficient for handling all the incoming IO. Unless we didn't
account for the first-page offset and the reminder coming at the last
segment (which results in an extra page). The patch should fix the
problem, however in this particular sg list I don't see the violation
(counted 127 pages)...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-04-07  7:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 13:46 iSER initiator in 4.5 is unhappy Christoph Hellwig
     [not found] ` <20160404134656.GA30269-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-04 14:42   ` Max Gurtovoy
     [not found]     ` <57027D48.4000500-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-04-04 15:10       ` Christoph Hellwig
2016-04-04 17:29   ` sagig
     [not found]     ` <5702A46F.5070109-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-04 17:38       ` sagig
     [not found]         ` <5702A6AC.9020008-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-04 22:58           ` Christoph Hellwig
     [not found]             ` <20160404225831.GA6725-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-05  8:55               ` sagig
     [not found]                 ` <57037D8E.4030506-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-05  9:43                   ` Christoph Hellwig
     [not found]                     ` <20160405094339.GA1622-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-06 17:34                       ` sagig
     [not found]                         ` <570548AB.4090802-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-06 23:16                           ` Christoph Hellwig
     [not found]                             ` <20160406231658.GB11588-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-07  7:14                               ` Sagi Grimberg [this message]
     [not found]                                 ` <570608C9.1070805-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-07  9:09                                   ` Max Gurtovoy
     [not found]                                     ` <570623B9.8040108-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-04-07 15:16                                       ` Sagi Grimberg
     [not found]                                         ` <570679B6.10409-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-07 15:20                                           ` Christoph Hellwig
2016-04-07 22:13                                           ` Christoph Hellwig
     [not found]                                             ` <20160407221359.GA16686-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-08  1:42                                               ` Bart Van Assche
2016-04-10 13:30                                               ` Max Gurtovoy
     [not found]                                                 ` <570A5563.5060104-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-04-10 14:52                                                   ` Christoph Hellwig
2016-04-12 21:33                                               ` Bart Van Assche
2016-04-04 22:46       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570608C9.1070805@grimberg.me \
    --to=sagi-nqwnxtmzq1alnmji0ikvqw@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.