From: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: iSER initiator in 4.5 is unhappy..
Date: Sun, 10 Apr 2016 16:30:11 +0300 [thread overview]
Message-ID: <570A5563.5060104@mellanox.com> (raw)
In-Reply-To: <20160407221359.GA16686-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On 4/8/2016 1:13 AM, Christoph Hellwig wrote:
> The patch below fixes the issue for me. But for SRP I'm still seeing
> lots of these failures even with the equivalent patch applied:
>
> [ 426.027905] scsi host8: ib_srp: Failed to map data (-12)
> [ 426.053203] scsi host8: ib_srp: Failed to map data (-12)
> [ 426.053265] scsi host8: ib_srp: Failed to map data (-12)
> [ 426.053270] scsi host8: ib_srp: Failed to map data (-12)
> [ 426.053273] scsi host8: ib_srp: Failed to map data (-12)
> [ 426.053276] scsi host8: ib_srp: Failed to map data (-12)
> [ 426.053279] scsi host8: ib_srp: Failed to map data (-12)
>
> It seems the actual reproducer is xfs_repair as run by xfstests.
>
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 60b169a..3ac4755 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -3205,6 +3205,7 @@ static ssize_t srp_create_target(struct device *dev,
> target_host->max_id = 1;
> target_host->max_lun = -1LL;
> target_host->max_cmd_len = sizeof ((struct srp_cmd *) (void *) 0L)->cdb;
> + target_host->max_segment_size = PAGE_SIZE;
>
> target = host_to_target(target_host);
Hi Christoph,
did you add similar assignment in iser code or only used the scsi patches ?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-10 13:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 13:46 iSER initiator in 4.5 is unhappy Christoph Hellwig
[not found] ` <20160404134656.GA30269-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-04 14:42 ` Max Gurtovoy
[not found] ` <57027D48.4000500-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-04-04 15:10 ` Christoph Hellwig
2016-04-04 17:29 ` sagig
[not found] ` <5702A46F.5070109-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-04 17:38 ` sagig
[not found] ` <5702A6AC.9020008-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-04 22:58 ` Christoph Hellwig
[not found] ` <20160404225831.GA6725-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-05 8:55 ` sagig
[not found] ` <57037D8E.4030506-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-05 9:43 ` Christoph Hellwig
[not found] ` <20160405094339.GA1622-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-06 17:34 ` sagig
[not found] ` <570548AB.4090802-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-06 23:16 ` Christoph Hellwig
[not found] ` <20160406231658.GB11588-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-07 7:14 ` Sagi Grimberg
[not found] ` <570608C9.1070805-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-07 9:09 ` Max Gurtovoy
[not found] ` <570623B9.8040108-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-04-07 15:16 ` Sagi Grimberg
[not found] ` <570679B6.10409-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-07 15:20 ` Christoph Hellwig
2016-04-07 22:13 ` Christoph Hellwig
[not found] ` <20160407221359.GA16686-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-08 1:42 ` Bart Van Assche
2016-04-10 13:30 ` Max Gurtovoy [this message]
[not found] ` <570A5563.5060104-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-04-10 14:52 ` Christoph Hellwig
2016-04-12 21:33 ` Bart Van Assche
2016-04-04 22:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570A5563.5060104@mellanox.com \
--to=maxg-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.