From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: alex@alex.org.uk
Subject: Re: [Qemu-devel] [PATCH v2 2/1 for-2.6] nbd: Don't kill server when client requests unknown option
Date: Thu, 7 Apr 2016 10:50:19 +0200 [thread overview]
Message-ID: <57061F4B.5050704@redhat.com> (raw)
In-Reply-To: <1459982918-32229-1-git-send-email-eblake@redhat.com>
On 07/04/2016 00:48, Eric Blake wrote:
> nbd-server.c currently fails to handle unsupported options properly.
> If during option haggling the client sends an unknown request, the
> server kills the connection instead of letting the client try to
> fall back to something older. This is precisely what advertising
> NBD_FLAG_FIXED_NEWSTYLE was supposed to fix.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> Turns out our server has a very similar bug to the client.
> If desired, I can spin a v3 that moves the hunk in nbd/client.c
> to the previous patch.
I'll do that myself. Thanks for the patches!
Paolo
next prev parent reply other threads:[~2016-04-07 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 16:59 [Qemu-devel] [PATCH v2] nbd: Fix NBD unsupported options Eric Blake
2016-04-06 22:48 ` [Qemu-devel] [PATCH v2 2/1 for-2.6] nbd: Don't kill server when client requests unknown option Eric Blake
2016-04-07 8:50 ` Paolo Bonzini [this message]
2016-04-09 22:41 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57061F4B.5050704@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.