From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com,
agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown
Date: Thu, 7 Apr 2016 13:45:19 -0400 [thread overview]
Message-ID: <57069CAF.8090803@codeaurora.org> (raw)
In-Reply-To: <20160407160624.GB8780@localhost>
On 4/7/2016 12:06 PM, Bjorn Helgaas wrote:
>> __release_pci_root_info function if the region type is IO.
> I don't know what "removing a slot" means. You're changing
> pci_root.c, so I assume this is really an ACPI host bridge removal?
>
Correct, I'm removing the host bridge.
> The release should correspond to a mapping, and the changelog should
> point out where that mapping happens so we can see the symmetry.
>
I apologize. This is based on Tomasz's v5 patch here.
https://github.com/semihalf-nowicki-tomasz/linux/blob/pci-acpi-v5/drivers/acpi/pci_root.c
> You say this is undoing the effect of pci_remap_iospace(), but that's
> only called by native drivers and the generic (OF) driver, not by
> pci_root.c.
See the ACPI root bridge driver above.
>
> Please combine this with the previous patch so we have the new
> function and its use in the same patch.
>
I can do that. I was trying to keep the reviews as small as possible.
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pci, acpi: free IO resource during shutdown
Date: Thu, 7 Apr 2016 13:45:19 -0400 [thread overview]
Message-ID: <57069CAF.8090803@codeaurora.org> (raw)
In-Reply-To: <20160407160624.GB8780@localhost>
On 4/7/2016 12:06 PM, Bjorn Helgaas wrote:
>> __release_pci_root_info function if the region type is IO.
> I don't know what "removing a slot" means. You're changing
> pci_root.c, so I assume this is really an ACPI host bridge removal?
>
Correct, I'm removing the host bridge.
> The release should correspond to a mapping, and the changelog should
> point out where that mapping happens so we can see the symmetry.
>
I apologize. This is based on Tomasz's v5 patch here.
https://github.com/semihalf-nowicki-tomasz/linux/blob/pci-acpi-v5/drivers/acpi/pci_root.c
> You say this is undoing the effect of pci_remap_iospace(), but that's
> only called by native drivers and the generic (OF) driver, not by
> pci_root.c.
See the ACPI root bridge driver above.
>
> Please combine this with the previous patch so we have the new
> function and its use in the same patch.
>
I can do that. I was trying to keep the reviews as small as possible.
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-07 17:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 22:21 [PATCH 1/2] pci: add pci_unmap_iospace function for PCI_IOBASE Sinan Kaya
2016-03-07 22:21 ` Sinan Kaya
2016-03-07 22:21 ` [PATCH 2/2] pci, acpi: free IO resource during shutdown Sinan Kaya
2016-03-07 22:21 ` Sinan Kaya
2016-04-07 16:06 ` Bjorn Helgaas
2016-04-07 16:06 ` Bjorn Helgaas
2016-04-07 17:45 ` Sinan Kaya [this message]
2016-04-07 17:45 ` Sinan Kaya
2016-04-07 21:41 ` Bjorn Helgaas
2016-04-07 21:41 ` Bjorn Helgaas
2016-04-08 3:40 ` Sinan Kaya
2016-04-08 3:40 ` Sinan Kaya
2016-04-08 6:51 ` Tomasz Nowicki
2016-04-08 6:51 ` Tomasz Nowicki
2016-04-08 17:46 ` Sinan Kaya
2016-04-08 17:46 ` Sinan Kaya
2016-04-09 8:44 ` Tomasz Nowicki
2016-04-09 8:44 ` Tomasz Nowicki
2016-03-16 23:14 ` [PATCH 1/2] pci: add pci_unmap_iospace function for PCI_IOBASE Sinan Kaya
2016-03-16 23:14 ` Sinan Kaya
2016-04-07 16:00 ` Bjorn Helgaas
2016-04-07 16:00 ` Bjorn Helgaas
2016-04-07 17:49 ` Sinan Kaya
2016-04-07 17:49 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57069CAF.8090803@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=jcm@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.