From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: kvm@vger.kernel.org, marc.zyngier@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/17] arm64: Cleanup VTCR_EL2 and VTTBR field values
Date: Fri, 8 Apr 2016 13:45:41 +0100 [thread overview]
Message-ID: <5707A7F5.1010104@arm.com> (raw)
In-Reply-To: <20160408124346.GN8961@cbox>
On 08/04/16 13:43, Christoffer Dall wrote:
>> +#define VTCR_EL2_T0SZ_IPA VTCR_EL2_T0SZ_40B
>> +#define VTCR_EL2_COMMON_BITS (VTCR_EL2_SH0_INNER | VTCR_EL2_ORGN0_WBWA | \
>> + VTCR_EL2_IRGN0_WBWA | VTCR_EL2_SL0_LVL1 | \
>> + VTCR_EL2_RES1 | VTCR_EL2_T0SZ_IPA)
>> #ifdef CONFIG_ARM64_64K_PAGES
>> /*
>> * Stage2 translation configuration:
>> - * 40bits input (T0SZ = 24)
>> * 64kB pages (TG0 = 1)
>> * 2 level page tables (SL = 1)
>> */
>> -#define VTCR_EL2_FLAGS (VTCR_EL2_TG0_64K | VTCR_EL2_SH0_INNER | \
>> - VTCR_EL2_ORGN0_WBWA | VTCR_EL2_IRGN0_WBWA | \
>> - VTCR_EL2_SL0_LVL1 | VTCR_EL2_T0SZ_40B | \
>> - VTCR_EL2_RES1)
>> -#define VTTBR_X (38 - VTCR_EL2_T0SZ_40B)
>> +#define VTCR_EL2_TGRAN_FLAGS (VTCR_EL2_TG0_64K | VTCR_EL2_SL0_LVL1)
>> +#define VTTBR_X_TGRAN_MAGIC 38
>> #else
>> /*
>> * Stage2 translation configuration:
>> - * 40bits input (T0SZ = 24)
>> * 4kB pages (TG0 = 0)
>> * 3 level page tables (SL = 1)
>> */
>> -#define VTCR_EL2_FLAGS (VTCR_EL2_TG0_4K | VTCR_EL2_SH0_INNER | \
>> - VTCR_EL2_ORGN0_WBWA | VTCR_EL2_IRGN0_WBWA | \
>> - VTCR_EL2_SL0_LVL1 | VTCR_EL2_T0SZ_40B | \
>> - VTCR_EL2_RES1)
>> -#define VTTBR_X (37 - VTCR_EL2_T0SZ_40B)
>> +#define VTCR_EL2_TGRAN_FLAGS (VTCR_EL2_TG0_4K | VTCR_EL2_SL0_LVL1)
>> +#define VTTBR_X_TGRAN_MAGIC 37
>> #endif
>
> why do we add VTCR_EL2_SL0_LVL1 in both the common bits and TGRAN_FLAGS
> define?
Oops! It should only be part of TGRAN_FLAGS. Thanks for spotting, will fix it.
> Otherwise:
>
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Thanks
Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki.Poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/17] arm64: Cleanup VTCR_EL2 and VTTBR field values
Date: Fri, 8 Apr 2016 13:45:41 +0100 [thread overview]
Message-ID: <5707A7F5.1010104@arm.com> (raw)
In-Reply-To: <20160408124346.GN8961@cbox>
On 08/04/16 13:43, Christoffer Dall wrote:
>> +#define VTCR_EL2_T0SZ_IPA VTCR_EL2_T0SZ_40B
>> +#define VTCR_EL2_COMMON_BITS (VTCR_EL2_SH0_INNER | VTCR_EL2_ORGN0_WBWA | \
>> + VTCR_EL2_IRGN0_WBWA | VTCR_EL2_SL0_LVL1 | \
>> + VTCR_EL2_RES1 | VTCR_EL2_T0SZ_IPA)
>> #ifdef CONFIG_ARM64_64K_PAGES
>> /*
>> * Stage2 translation configuration:
>> - * 40bits input (T0SZ = 24)
>> * 64kB pages (TG0 = 1)
>> * 2 level page tables (SL = 1)
>> */
>> -#define VTCR_EL2_FLAGS (VTCR_EL2_TG0_64K | VTCR_EL2_SH0_INNER | \
>> - VTCR_EL2_ORGN0_WBWA | VTCR_EL2_IRGN0_WBWA | \
>> - VTCR_EL2_SL0_LVL1 | VTCR_EL2_T0SZ_40B | \
>> - VTCR_EL2_RES1)
>> -#define VTTBR_X (38 - VTCR_EL2_T0SZ_40B)
>> +#define VTCR_EL2_TGRAN_FLAGS (VTCR_EL2_TG0_64K | VTCR_EL2_SL0_LVL1)
>> +#define VTTBR_X_TGRAN_MAGIC 38
>> #else
>> /*
>> * Stage2 translation configuration:
>> - * 40bits input (T0SZ = 24)
>> * 4kB pages (TG0 = 0)
>> * 3 level page tables (SL = 1)
>> */
>> -#define VTCR_EL2_FLAGS (VTCR_EL2_TG0_4K | VTCR_EL2_SH0_INNER | \
>> - VTCR_EL2_ORGN0_WBWA | VTCR_EL2_IRGN0_WBWA | \
>> - VTCR_EL2_SL0_LVL1 | VTCR_EL2_T0SZ_40B | \
>> - VTCR_EL2_RES1)
>> -#define VTTBR_X (37 - VTCR_EL2_T0SZ_40B)
>> +#define VTCR_EL2_TGRAN_FLAGS (VTCR_EL2_TG0_4K | VTCR_EL2_SL0_LVL1)
>> +#define VTTBR_X_TGRAN_MAGIC 37
>> #endif
>
> why do we add VTCR_EL2_SL0_LVL1 in both the common bits and TGRAN_FLAGS
> define?
Oops! It should only be part of TGRAN_FLAGS. Thanks for spotting, will fix it.
> Otherwise:
>
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Thanks
Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, marc.zyngier@arm.com, mark.rutland@arm.com,
will.deacon@arm.com, catalin.marinas@arm.com
Subject: Re: [PATCH 02/17] arm64: Cleanup VTCR_EL2 and VTTBR field values
Date: Fri, 8 Apr 2016 13:45:41 +0100 [thread overview]
Message-ID: <5707A7F5.1010104@arm.com> (raw)
In-Reply-To: <20160408124346.GN8961@cbox>
On 08/04/16 13:43, Christoffer Dall wrote:
>> +#define VTCR_EL2_T0SZ_IPA VTCR_EL2_T0SZ_40B
>> +#define VTCR_EL2_COMMON_BITS (VTCR_EL2_SH0_INNER | VTCR_EL2_ORGN0_WBWA | \
>> + VTCR_EL2_IRGN0_WBWA | VTCR_EL2_SL0_LVL1 | \
>> + VTCR_EL2_RES1 | VTCR_EL2_T0SZ_IPA)
>> #ifdef CONFIG_ARM64_64K_PAGES
>> /*
>> * Stage2 translation configuration:
>> - * 40bits input (T0SZ = 24)
>> * 64kB pages (TG0 = 1)
>> * 2 level page tables (SL = 1)
>> */
>> -#define VTCR_EL2_FLAGS (VTCR_EL2_TG0_64K | VTCR_EL2_SH0_INNER | \
>> - VTCR_EL2_ORGN0_WBWA | VTCR_EL2_IRGN0_WBWA | \
>> - VTCR_EL2_SL0_LVL1 | VTCR_EL2_T0SZ_40B | \
>> - VTCR_EL2_RES1)
>> -#define VTTBR_X (38 - VTCR_EL2_T0SZ_40B)
>> +#define VTCR_EL2_TGRAN_FLAGS (VTCR_EL2_TG0_64K | VTCR_EL2_SL0_LVL1)
>> +#define VTTBR_X_TGRAN_MAGIC 38
>> #else
>> /*
>> * Stage2 translation configuration:
>> - * 40bits input (T0SZ = 24)
>> * 4kB pages (TG0 = 0)
>> * 3 level page tables (SL = 1)
>> */
>> -#define VTCR_EL2_FLAGS (VTCR_EL2_TG0_4K | VTCR_EL2_SH0_INNER | \
>> - VTCR_EL2_ORGN0_WBWA | VTCR_EL2_IRGN0_WBWA | \
>> - VTCR_EL2_SL0_LVL1 | VTCR_EL2_T0SZ_40B | \
>> - VTCR_EL2_RES1)
>> -#define VTTBR_X (37 - VTCR_EL2_T0SZ_40B)
>> +#define VTCR_EL2_TGRAN_FLAGS (VTCR_EL2_TG0_4K | VTCR_EL2_SL0_LVL1)
>> +#define VTTBR_X_TGRAN_MAGIC 37
>> #endif
>
> why do we add VTCR_EL2_SL0_LVL1 in both the common bits and TGRAN_FLAGS
> define?
Oops! It should only be part of TGRAN_FLAGS. Thanks for spotting, will fix it.
> Otherwise:
>
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Thanks
Suzuki
next prev parent reply other threads:[~2016-04-08 12:44 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 16:26 [PATCH 00/17] kvm-arm: Add stage2 page table walker Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` [PATCH 01/17] arm64: Reuse TCR field definitions for EL1 and EL2 Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 02/17] arm64: Cleanup VTCR_EL2 and VTTBR field values Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:45 ` Suzuki K Poulose [this message]
2016-04-08 12:45 ` Suzuki K Poulose
2016-04-08 12:45 ` Suzuki K Poulose
2016-04-04 16:26 ` [PATCH 03/17] kvm arm: Move fake PGD handling to arch specific files Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` [PATCH 04/17] arm64: Introduce pmd_thp_or_huge Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 05/17] kvm-arm: Replace kvm_pmd_huge with pmd_thp_or_huge Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 06/17] kvm-arm: Remove kvm_pud_huge() Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 12:44 ` Christoffer Dall
2016-04-08 12:44 ` Christoffer Dall
2016-04-08 12:44 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 07/17] kvm-arm: arm32: Introduce stage2 page table helpers Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 12:43 ` Christoffer Dall
2016-04-08 14:39 ` Suzuki K Poulose
2016-04-08 14:39 ` Suzuki K Poulose
2016-04-08 14:39 ` Suzuki K Poulose
2016-04-04 16:26 ` [PATCH 08/17] kvm-arm: arm: Introduce hyp page table empty checks Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 09/17] kvm-arm: arm64: Introduce stage2 page table helpers Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 10/17] kvm-arm: arm64: Introduce hyp page table empty checks Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 11/17] kvm-arm: Use explicit stage2 helper routines Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 13:16 ` Christoffer Dall
2016-04-08 13:16 ` Christoffer Dall
2016-04-08 13:16 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 12/17] kvm-arm: Add explicit hyp page table modifiers Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 13:15 ` Christoffer Dall
2016-04-08 15:09 ` Marc Zyngier
2016-04-08 15:09 ` Marc Zyngier
2016-04-08 15:09 ` Marc Zyngier
2016-04-08 15:16 ` Christoffer Dall
2016-04-08 15:16 ` Christoffer Dall
2016-04-08 15:16 ` Christoffer Dall
2016-04-08 15:22 ` Marc Zyngier
2016-04-08 15:22 ` Marc Zyngier
2016-04-08 15:22 ` Marc Zyngier
2016-04-08 15:22 ` Suzuki K Poulose
2016-04-08 15:22 ` Suzuki K Poulose
2016-04-08 15:22 ` Suzuki K Poulose
2016-04-08 15:25 ` Christoffer Dall
2016-04-08 15:25 ` Christoffer Dall
2016-04-08 15:25 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 13/17] kvm-arm: Add stage2 " Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 13:42 ` Christoffer Dall
2016-04-08 13:42 ` Christoffer Dall
2016-04-08 13:42 ` Christoffer Dall
2016-04-08 15:37 ` Suzuki K Poulose
2016-04-08 15:37 ` Suzuki K Poulose
2016-04-08 15:37 ` Suzuki K Poulose
2016-04-08 17:03 ` Christoffer Dall
2016-04-08 17:03 ` Christoffer Dall
2016-04-08 17:03 ` Christoffer Dall
2016-04-08 17:07 ` Suzuki K Poulose
2016-04-08 17:07 ` Suzuki K Poulose
2016-04-08 17:07 ` Suzuki K Poulose
2016-04-08 17:25 ` Christoffer Dall
2016-04-08 17:25 ` Christoffer Dall
2016-04-08 17:25 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 14/17] kvm-arm: Cleanup kvm_* wrappers Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 15:05 ` Christoffer Dall
2016-04-08 15:05 ` Christoffer Dall
2016-04-08 15:05 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 15/17] kvm: arm64: Get rid of fake page table levels Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 15:05 ` Christoffer Dall
2016-04-08 15:05 ` Christoffer Dall
2016-04-08 15:05 ` Christoffer Dall
2016-04-11 14:33 ` Suzuki K Poulose
2016-04-11 14:33 ` Suzuki K Poulose
2016-04-11 14:33 ` Suzuki K Poulose
2016-04-12 12:14 ` Christoffer Dall
2016-04-12 12:14 ` Christoffer Dall
2016-04-12 12:14 ` Christoffer Dall
2016-04-12 13:03 ` Suzuki K Poulose
2016-04-12 13:03 ` Suzuki K Poulose
2016-04-12 13:03 ` Suzuki K Poulose
2016-04-12 13:11 ` Christoffer Dall
2016-04-12 13:11 ` Christoffer Dall
2016-04-12 13:11 ` Christoffer Dall
2016-04-13 17:49 ` Suzuki K Poulose
2016-04-13 17:49 ` Suzuki K Poulose
2016-04-13 17:49 ` Suzuki K Poulose
2016-04-14 12:18 ` Christoffer Dall
2016-04-14 12:18 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 16/17] kvm-arm: Cleanup stage2 pgd handling Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 15:08 ` Christoffer Dall
2016-04-08 15:08 ` Christoffer Dall
2016-04-08 15:08 ` Christoffer Dall
2016-04-04 16:26 ` [PATCH 17/17] arm64: kvm: Add support for 16K pages Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-04 16:26 ` Suzuki K Poulose
2016-04-08 15:13 ` Christoffer Dall
2016-04-08 15:13 ` Christoffer Dall
2016-04-08 15:13 ` Christoffer Dall
2016-04-08 15:15 ` [PATCH 00/17] kvm-arm: Add stage2 page table walker Christoffer Dall
2016-04-08 15:15 ` Christoffer Dall
2016-04-08 15:15 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5707A7F5.1010104@arm.com \
--to=suzuki.poulose@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.