Re: [PATCH v5] xen/arm64: check XSM Magic from the second unknown module.

[Julien Grall <julien.grall@arm.com>]

Hi Fu Wei,

On 05/04/16 17:46, fu.wei@linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patch adds a has_xsm_magic helper function for detecting XSM
> from the second unknown module.
>
> If Xen can't get the kind of module from compatible, we guess the kind of
> these unknowns respectively:
>      (1) The first unknown must be kernel.
>      (2) Detect the XSM Magic from the 2nd unknown:
>          a. If it's XSM, set the kind as XSM, and that also means we
> 	won't load ramdisk;
> 	b. if it's not XSM, set the kind as ramdisk.
> 	So if user want to load ramdisk, it must be the 2nd unknown.

The documentation in docs/misc/arm/device-tree/booting.txt needs to be 
update.

Otherwise, the rest of the patch looks good to me.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel