All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xensource.com, jcm@redhat.com,
	leif.lindholm@linaro.org, sstabellini@kernel.org,
	linaro-uefi@lists.linaro.org, dgdegra@tycho.nsa.gov,
	fu.wei@linaro.org
Subject: Re: [PATCH v5] xen/arm64: check XSM Magic from the second unknown module.
Date: Fri, 8 Apr 2016 16:19:44 +0100	[thread overview]
Message-ID: <5707CC10.9040501@arm.com> (raw)
In-Reply-To: <20160408145842.GA3789@citrix.com>

Hi Wei,

On 08/04/16 15:58, Wei Liu wrote:
> On Fri, Apr 08, 2016 at 03:51:22PM +0100, Julien Grall wrote:
>> Hi Fu Wei,
>>
>> On 05/04/16 17:46, fu.wei@linaro.org wrote:
>>> From: Fu Wei <fu.wei@linaro.org>
>>>
>>> This patch adds a has_xsm_magic helper function for detecting XSM
>> >from the second unknown module.
>>>
>>> If Xen can't get the kind of module from compatible, we guess the kind of
>>> these unknowns respectively:
>>>      (1) The first unknown must be kernel.
>>>      (2) Detect the XSM Magic from the 2nd unknown:
>>>          a. If it's XSM, set the kind as XSM, and that also means we
>>> 	won't load ramdisk;
>>> 	b. if it's not XSM, set the kind as ramdisk.
>>> 	So if user want to load ramdisk, it must be the 2nd unknown.
>>
>> The documentation in docs/misc/arm/device-tree/booting.txt needs to be
>> update.
>>
>> Otherwise, the rest of the patch looks good to me.
>>
>> Regards,
>>
>
> Is this targeting 4.7? Today is the last day for committing stuff. The
> doc can come in later.

Yes, it's targeting 4.7. Fu Wei, can you send a follow-up for the doc?

>
> Julien and Daniel's acks are needed here.

Acked-by: Julien Grall <julien.grall@arm.com>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-08 15:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 16:46 [PATCH v5] xen/arm64: check XSM Magic from the second unknown module fu.wei
2016-04-08 14:51 ` Julien Grall
2016-04-08 14:58   ` Wei Liu
2016-04-08 15:19     ` Julien Grall [this message]
2016-04-13  9:45       ` Fu Wei
2016-04-15  9:47         ` Wei Liu
2016-04-19 12:32           ` Fu Wei
2016-04-19 14:56             ` Wei Liu
2016-04-13  9:43   ` Fu Wei
2016-04-08 15:12 ` Daniel De Graaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5707CC10.9040501@arm.com \
    --to=julien.grall@arm.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=fu.wei@linaro.org \
    --cc=jcm@redhat.com \
    --cc=leif.lindholm@linaro.org \
    --cc=linaro-uefi@lists.linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.