[PATCH] advsync: Another fix to use latex reference feature consistently

[PATCH] advsync: Another fix to use latex reference feature consistently

[Akira Yokosawa]

Hello,

This is the first time I submit a patch.
I'm not sure the format below is acceptable or not, but just trying.
If there is any issue, please advise me.

Regards,

Akira Yokosawa <akiyks@gmail.com>

-- >8 --
Subject: [PATCH] advsync: Another fix to use latex reference feature consistently

In commit 91bde6aa87c2884f19d2a83534236cdbb319d625, SeongJae Park
has made changes to enforce latex reference feature to the references
in the `Advanced Synchronization` chapter. However one of section
name direct citations is left unchanged in the commit.
This commit fixes the remaining one.

Signed-off-by: Akira Yokosawa <akiysw@gmail.com>
---
 advsync/memorybarriers.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
index 12771ec..e527def 100644
--- a/advsync/memorybarriers.tex
+++ b/advsync/memorybarriers.tex
@@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute
 for them.

 $\dagger$ Note that read barriers should normally be paired with write barriers;
-see the ``SMP barrier pairing'' subsection.
+see Secton~\ref{sec:advsync:SMP Barrier Pairing}.

 \paragraph{General Memory Barriers}

-- 
1.9.1

Re: [PATCH] advsync: Another fix to use latex reference feature consistently

[SeongJae Park]

Hello,

The patch looks good to me.  Just FYI, however, I think it would be
better to use `git format-patch` for patch creation because a patch that
made with the command can be merged in git repository more easily.

Acked-by: SeongJae Park <sj38.park@gmail.com>

On Sat, 9 Apr 2016, Akira Yokosawa wrote:

> Hello,
>
> This is the first time I submit a patch.
> I'm not sure the format below is acceptable or not, but just trying.
> If there is any issue, please advise me.
>
> Regards,
>
> Akira Yokosawa <akiyks@gmail.com>
>
> -- >8 --
> Subject: [PATCH] advsync: Another fix to use latex reference feature consistently
>
> In commit 91bde6aa87c2884f19d2a83534236cdbb319d625, SeongJae Park
> has made changes to enforce latex reference feature to the references
> in the `Advanced Synchronization` chapter. However one of section
> name direct citations is left unchanged in the commit.
> This commit fixes the remaining one.
>
> Signed-off-by: Akira Yokosawa <akiysw@gmail.com>
> ---
> advsync/memorybarriers.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
> index 12771ec..e527def 100644
> --- a/advsync/memorybarriers.tex
> +++ b/advsync/memorybarriers.tex
> @@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute
> for them.
>
> $\dagger$ Note that read barriers should normally be paired with write barriers;
> -see the ``SMP barrier pairing'' subsection.
> +see Secton~\ref{sec:advsync:SMP Barrier Pairing}.
>
> \paragraph{General Memory Barriers}
>
> -- 
> 1.9.1
>
>

Re: [PATCH] advsync: Another fix to use latex reference feature consistently

[Paul E. McKenney]

On Sat, Apr 09, 2016 at 02:46:15PM +0900, SeongJae Park wrote:
> Hello,
> 
> The patch looks good to me.  Just FYI, however, I think it would be
> better to use `git format-patch` for patch creation because a patch that
> made with the command can be merged in git repository more easily.
> 
> Acked-by: SeongJae Park <sj38.park@gmail.com>

Queued with SeongJae's Acked-by, thank you both.

Akira, in the future, please do use "git format-patch" and also please
use the Linux-kernel preferred format for referencing commits, as shown
in the updated commit below.  The idea is to use the first 12 digits of
the SHA-1 commit ID, followed by the subject line in both quotes and
parentheses.

							Thanx, Paul

> On Sat, 9 Apr 2016, Akira Yokosawa wrote:
> 
> >Hello,
> >
> >This is the first time I submit a patch.
> >I'm not sure the format below is acceptable or not, but just trying.
> >If there is any issue, please advise me.
> >
> >Regards,
> >
> >Akira Yokosawa <akiyks@gmail.com>
> >
> >-- >8 --
> >Subject: [PATCH] advsync: Another fix to use latex reference feature consistently
> >
> >In commit 91bde6aa87c2884f19d2a83534236cdbb319d625, SeongJae Park
> >has made changes to enforce latex reference feature to the references
> >in the `Advanced Synchronization` chapter. However one of section
> >name direct citations is left unchanged in the commit.
> >This commit fixes the remaining one.
> >
> >Signed-off-by: Akira Yokosawa <akiysw@gmail.com>
> >---
> >advsync/memorybarriers.tex | 2 +-
> >1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
> >index 12771ec..e527def 100644
> >--- a/advsync/memorybarriers.tex
> >+++ b/advsync/memorybarriers.tex
> >@@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute
> >for them.
> >
> >$\dagger$ Note that read barriers should normally be paired with write barriers;
> >-see the ``SMP barrier pairing'' subsection.
> >+see Secton~\ref{sec:advsync:SMP Barrier Pairing}.
> >
> >\paragraph{General Memory Barriers}
> >
> >-- 
> >1.9.1

------------------------------------------------------------------------

commit 5795796caa89e7a5720b74a05886ba7c7f897725
Author: Akira Yokosawa <akiyks@gmail.com>
Date:   Tue Apr 12 08:56:45 2016 -0700

    advsync: Another fix to use latex reference feature consistently
    
    In commit 91bde6aa87c2 ("advsync: Use latex reference feature
    consistently"), SeongJae Park has made changes to enforce latex
    reference feature to the references in the `Advanced Synchronization`
    chapter. However one of section name direct citations is left unchanged
    in the commit.  This commit fixes the remaining one.
    
    Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
    Acked-by: SeongJae Park <sj38.park@gmail.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
index 12771ec38bee..e527def5b2ea 100644
--- a/advsync/memorybarriers.tex
+++ b/advsync/memorybarriers.tex
@@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute
 for them.

 $\dagger$ Note that read barriers should normally be paired with write barriers;
-see the ``SMP barrier pairing'' subsection.
+see Secton~\ref{sec:advsync:SMP Barrier Pairing}.

 \paragraph{General Memory Barriers}

Re: [PATCH] advsync: Another fix to use latex reference feature consistently

[Akira Yokosawa]

Hi, Paul,

On 2016/04/13 1:00, Paul E. McKenney wrote:
> Akira, in the future, please do use "git format-patch" and also please
> use the Linux-kernel preferred format for referencing commits, as shown
> in the updated commit below.  The idea is to use the first 12 digits of
> the SHA-1 commit ID, followed by the subject line in both quotes and
> parentheses.

I see. I'll do so in the future.
In fact, I *did* use "git format-patch", but copy & pasted part of the
output. I also edited the commit message just before sending it out.
I won't do that.

BTW, are you interested in a cosmetic patch which would make Section
14.2.9 "Guarantees" looks much denser by reducing vertical spaces above
and below code examples?

If it's worth doing, I'll try tuning them this weekend.

Thanks,

-- 
Akira Yokosawa <akiyks@gmail.com>

Re: [PATCH] advsync: Another fix to use latex reference feature consistently

[Paul E. McKenney]

On Wed, Apr 13, 2016 at 07:15:42AM +0900, Akira Yokosawa wrote:
> Hi, Paul,
> 
> On 2016/04/13 1:00, Paul E. McKenney wrote:
> > Akira, in the future, please do use "git format-patch" and also please
> > use the Linux-kernel preferred format for referencing commits, as shown
> > in the updated commit below.  The idea is to use the first 12 digits of
> > the SHA-1 commit ID, followed by the subject line in both quotes and
> > parentheses.
> 
> I see. I'll do so in the future.
> In fact, I *did* use "git format-patch", but copy & pasted part of the
> output. I also edited the commit message just before sending it out.
> I won't do that.
> 
> BTW, are you interested in a cosmetic patch which would make Section
> 14.2.9 "Guarantees" looks much denser by reducing vertical spaces above
> and below code examples?
> 
> If it's worth doing, I'll try tuning them this weekend.

Please do!

							Thanx, Paul