[PATCH] selinux,kbuild: remove unnecessary $(hostprogs-y) from clean-files

[PATCH] selinux,kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Masahiro Yamada]

Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
Adding them to clean-files is redundant.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 scripts/selinux/genheaders/Makefile | 1 -
 scripts/selinux/mdp/Makefile        | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/selinux/genheaders/Makefile b/scripts/selinux/genheaders/Makefile
index 417b165..1d1ac51 100644
--- a/scripts/selinux/genheaders/Makefile
+++ b/scripts/selinux/genheaders/Makefile
@@ -2,4 +2,3 @@ hostprogs-y	:= genheaders
 HOST_EXTRACFLAGS += -Isecurity/selinux/include
 
 always		:= $(hostprogs-y)
-clean-files	:= $(hostprogs-y)
diff --git a/scripts/selinux/mdp/Makefile b/scripts/selinux/mdp/Makefile
index eb365b3..dba7eff 100644
--- a/scripts/selinux/mdp/Makefile
+++ b/scripts/selinux/mdp/Makefile
@@ -2,4 +2,4 @@ hostprogs-y	:= mdp
 HOST_EXTRACFLAGS += -Isecurity/selinux/include
 
 always		:= $(hostprogs-y)
-clean-files	:= $(hostprogs-y) policy.* file_contexts
+clean-files	:= policy.* file_contexts
-- 
1.8.3.2

[PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Masahiro Yamada]

Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
Adding them to clean-files is redundant.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 scripts/selinux/genheaders/Makefile | 1 -
 scripts/selinux/mdp/Makefile        | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/selinux/genheaders/Makefile b/scripts/selinux/genheaders/Makefile
index 417b165..1d1ac51 100644
--- a/scripts/selinux/genheaders/Makefile
+++ b/scripts/selinux/genheaders/Makefile
@@ -2,4 +2,3 @@ hostprogs-y	:= genheaders
 HOST_EXTRACFLAGS += -Isecurity/selinux/include
 
 always		:= $(hostprogs-y)
-clean-files	:= $(hostprogs-y)
diff --git a/scripts/selinux/mdp/Makefile b/scripts/selinux/mdp/Makefile
index eb365b3..dba7eff 100644
--- a/scripts/selinux/mdp/Makefile
+++ b/scripts/selinux/mdp/Makefile
@@ -2,4 +2,4 @@ hostprogs-y	:= mdp
 HOST_EXTRACFLAGS += -Isecurity/selinux/include
 
 always		:= $(hostprogs-y)
-clean-files	:= $(hostprogs-y) policy.* file_contexts
+clean-files	:= policy.* file_contexts
-- 
1.8.3.2

Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Paul Moore]

On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> Adding them to clean-files is redundant.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
>  scripts/selinux/genheaders/Makefile | 1 -
>  scripts/selinux/mdp/Makefile        | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)

Acked-by: Paul Moore <paul@paul-moore.com>
 
> diff --git a/scripts/selinux/genheaders/Makefile
> b/scripts/selinux/genheaders/Makefile index 417b165..1d1ac51 100644
> --- a/scripts/selinux/genheaders/Makefile
> +++ b/scripts/selinux/genheaders/Makefile
> @@ -2,4 +2,3 @@ hostprogs-y	:= genheaders
>  HOST_EXTRACFLAGS += -Isecurity/selinux/include
> 
>  always		:= $(hostprogs-y)
> -clean-files	:= $(hostprogs-y)
> diff --git a/scripts/selinux/mdp/Makefile b/scripts/selinux/mdp/Makefile
> index eb365b3..dba7eff 100644
> --- a/scripts/selinux/mdp/Makefile
> +++ b/scripts/selinux/mdp/Makefile
> @@ -2,4 +2,4 @@ hostprogs-y	:= mdp
>  HOST_EXTRACFLAGS += -Isecurity/selinux/include
> 
>  always		:= $(hostprogs-y)
> -clean-files	:= $(hostprogs-y) policy.* file_contexts
> +clean-files	:= policy.* file_contexts

-- 
paul moore
www.paul-moore.com

Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Paul Moore]

On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> Adding them to clean-files is redundant.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
>  scripts/selinux/genheaders/Makefile | 1 -
>  scripts/selinux/mdp/Makefile        | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)

Acked-by: Paul Moore <paul@paul-moore.com>
 
> diff --git a/scripts/selinux/genheaders/Makefile
> b/scripts/selinux/genheaders/Makefile index 417b165..1d1ac51 100644
> --- a/scripts/selinux/genheaders/Makefile
> +++ b/scripts/selinux/genheaders/Makefile
> @@ -2,4 +2,3 @@ hostprogs-y	:= genheaders
>  HOST_EXTRACFLAGS += -Isecurity/selinux/include
> 
>  always		:= $(hostprogs-y)
> -clean-files	:= $(hostprogs-y)
> diff --git a/scripts/selinux/mdp/Makefile b/scripts/selinux/mdp/Makefile
> index eb365b3..dba7eff 100644
> --- a/scripts/selinux/mdp/Makefile
> +++ b/scripts/selinux/mdp/Makefile
> @@ -2,4 +2,4 @@ hostprogs-y	:= mdp
>  HOST_EXTRACFLAGS += -Isecurity/selinux/include
> 
>  always		:= $(hostprogs-y)
> -clean-files	:= $(hostprogs-y) policy.* file_contexts
> +clean-files	:= policy.* file_contexts

-- 
paul moore
www.paul-moore.com

Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Masahiro Yamada]

Hi Paul Moore,

On Thu, 17 Apr 2014 21:41:53 -0400
Paul Moore <paul@paul-moore.com> wrote:

> On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > Adding them to clean-files is redundant.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > ---
> > 
> >  scripts/selinux/genheaders/Makefile | 1 -
> >  scripts/selinux/mdp/Makefile        | 2 +-
> >  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> Acked-by: Paul Moore <paul@paul-moore.com>


It looks like this patch was not included into
GIT-PULL of "SELinux patches for 3.16".

Is it possible to apply this and send another pull request?

Best Regards
Masahiro Yamada

Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Paul Moore]

On Tuesday, June 03, 2014 02:47:39 PM Masahiro Yamada wrote:
> Hi Paul Moore,

Hello.

> On Thu, 17 Apr 2014 21:41:53 -0400 Paul Moore <paul@paul-moore.com> wrote:
> > On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > > Adding them to clean-files is redundant.
> > > 
> > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > ---
> > > 
> > >  scripts/selinux/genheaders/Makefile | 1 -
> > >  scripts/selinux/mdp/Makefile        | 2 +-
> > >  2 files changed, 1 insertion(+), 2 deletions(-)
> > 
> > Acked-by: Paul Moore <paul@paul-moore.com>
> 
> It looks like this patch was not included into
> GIT-PULL of "SELinux patches for 3.16".
> 
> Is it possible to apply this and send another pull request?

My apologies, I thought the kbuild people were going to merge this patch; this 
is why I sent my Acked-by instead of a note that I've merged the patch.  
Considering that this patch doesn't actually fix any runtime problems and it 
hasn't been in any of the different "next" trees, I think it is best to wait 
until 3.17 for this patch.

I've added this patch to my queue of patches to be added to the SELinux #next 
branch after the 3.16 merge window closes.

Thanks again for the patch, I'm sorry that we didn't get it merged sooner.

-- 
paul moore
www.paul-moore.com

Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Masahiro Yamada]

Hi Paul, Michal,

On Tue, 03 Jun 2014 18:27:41 -0400
Paul Moore <paul@paul-moore.com> wrote:

> On Tuesday, June 03, 2014 02:47:39 PM Masahiro Yamada wrote:
> > Hi Paul Moore,
> 
> Hello.
> 
> > On Thu, 17 Apr 2014 21:41:53 -0400 Paul Moore <paul@paul-moore.com> wrote:
> > > On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > > > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > > > Adding them to clean-files is redundant.
> > > > 
> > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > > ---
> > > > 
> > > >  scripts/selinux/genheaders/Makefile | 1 -
> > > >  scripts/selinux/mdp/Makefile        | 2 +-
> > > >  2 files changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > Acked-by: Paul Moore <paul@paul-moore.com>
> > 
> > It looks like this patch was not included into
> > GIT-PULL of "SELinux patches for 3.16".
> > 
> > Is it possible to apply this and send another pull request?
> 
> My apologies, I thought the kbuild people were going to merge this patch; this 
> is why I sent my Acked-by instead of a note that I've merged the patch.  
> Considering that this patch doesn't actually fix any runtime problems and it 
> hasn't been in any of the different "next" trees, I think it is best to wait 
> until 3.17 for this patch.
> 
> I've added this patch to my queue of patches to be added to the SELinux #next 
> branch after the 3.16 merge window closes.
> 
> Thanks again for the patch, I'm sorry that we didn't get it merged sooner.

No worries.

Michal, could you apply this patch to kbuild.git#kbuild, please?


Best Regards
Masahiro Yamada

Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files

[Paul Moore]

On Thursday, June 05, 2014 04:18:23 PM Masahiro Yamada wrote:
> Hi Paul, Michal,
> 
> On Tue, 03 Jun 2014 18:27:41 -0400
> 
> Paul Moore <paul@paul-moore.com> wrote:
> > On Tuesday, June 03, 2014 02:47:39 PM Masahiro Yamada wrote:
> > > Hi Paul Moore,
> > 
> > Hello.
> > 
> > > On Thu, 17 Apr 2014 21:41:53 -0400 Paul Moore wrote:
> > > > On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > > > > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > > > > Adding them to clean-files is redundant.
> > > > > 
> > > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > > > ---
> > > > > 
> > > > >  scripts/selinux/genheaders/Makefile | 1 -
> > > > >  scripts/selinux/mdp/Makefile        | 2 +-
> > > > >  2 files changed, 1 insertion(+), 2 deletions(-)
> > > > 
> > > > Acked-by: Paul Moore <paul@paul-moore.com>
> > > 
> > > It looks like this patch was not included into
> > > GIT-PULL of "SELinux patches for 3.16".
> > > 
> > > Is it possible to apply this and send another pull request?
> > 
> > My apologies, I thought the kbuild people were going to merge this patch;
> > this is why I sent my Acked-by instead of a note that I've merged the
> > patch. Considering that this patch doesn't actually fix any runtime
> > problems and it hasn't been in any of the different "next" trees, I think
> > it is best to wait until 3.17 for this patch.
> > 
> > I've added this patch to my queue of patches to be added to the SELinux
> > #next branch after the 3.16 merge window closes.
> > 
> > Thanks again for the patch, I'm sorry that we didn't get it merged sooner.
> 
> No worries.
> 
> Michal, could you apply this patch to kbuild.git#kbuild, please?

As I said, it is not a problem for me to carry the patch in the SELinux tree.

-- 
paul moore
www.paul-moore.com